Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enterprise Search] disable adding ml pipelines to default ingest pipeline #141169

Conversation

TattdCodeMonkey
Copy link
Contributor

@TattdCodeMonkey TattdCodeMonkey commented Sep 20, 2022

Summary

Disabled the Add Inference pipeline button if there is not an index specific ingestion pipeline already created.
image

@TattdCodeMonkey TattdCodeMonkey added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:EnterpriseSearch v8.5.0 labels Sep 20, 2022
@TattdCodeMonkey TattdCodeMonkey requested a review from a team September 20, 2022 21:15
Copy link
Contributor

@markjhoy markjhoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 love the tooltip with the better explanation for why it's disabled

Copy link
Contributor

@brianmcgue brianmcgue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is definitely a better message/UX, but it's still not super obvious where/how to "copy and customize the default ingest pipeline"

Maybe we should have @daveyholler take a look at the various interactions on this page.

@TattdCodeMonkey
Copy link
Contributor Author

@elasticmachine merge upstream

1 similar comment
@brianmcgue
Copy link
Contributor

@elasticmachine merge upstream

@TattdCodeMonkey TattdCodeMonkey force-pushed the rnorris/index-pipelines-gate-ml-for-index-pipelines branch from 64a4e5a to 9152a3e Compare September 21, 2022 14:26
@TattdCodeMonkey TattdCodeMonkey removed the backport:skip This commit does not require backporting label Sep 21, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 1.7MB 1.7MB +589.0B

History

  • 💚 Build #74286 succeeded 64a4e5a7c5385005c47ca2e968ab6383a01dff5f
  • 💚 Build #74257 succeeded 647c53e399d3dce499e0ac06c1e374addd7aef6f
  • 💔 Build #74236 failed af4db283c2e16ea72f9b62df776313b97db3ee64

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@TattdCodeMonkey TattdCodeMonkey merged commit f6f5efd into elastic:main Sep 21, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants