Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIP] Remove feature flag for Threat Intelligence plugin #141117

Merged
merged 3 commits into from
Sep 26, 2022
Merged

[TIP] Remove feature flag for Threat Intelligence plugin #141117

merged 3 commits into from
Sep 26, 2022

Conversation

PhilippeOberti
Copy link
Contributor

@PhilippeOberti PhilippeOberti commented Sep 20, 2022 •
edited by kibanamachine
Loading

Summary

The Threat Intelligence plugin has been hidden behind a feature flag since early August (ticket and PR).

We are now ready to go GA for 8.5 release! This current PR removes the threatIntelligenceEnabled feature flag from the Security Solution plugin.
This solves only the first AC of this going GA ticket.

Notes:

  • this other PR modifies the Threat Intelligence README file. It might not be necessary anymore after the feature flag is removed
  • depending on the decision made in this other PR, we might need to go update the development-setup.mdx file in the security-team repo.

https://github.com/elastic/security-team/issues/5077

Checklist

@PhilippeOberti PhilippeOberti marked this pull request as ready for review September 23, 2022 17:36
@PhilippeOberti PhilippeOberti requested review from a team as code owners September 23, 2022 17:36
@PhilippeOberti PhilippeOberti added 8.5 candidate v8.5.0 release_note:skip Skip the PR/issue when compiling release notes labels Sep 23, 2022
@PhilippeOberti
Copy link
Contributor Author

Files by Code Owner

elastic/protections-experience

  • x-pack/plugins/security_solution/public/threat_intelligence/links.ts
  • x-pack/plugins/security_solution/public/threat_intelligence/routes.tsx
  • x-pack/test/threat_intelligence_cypress/config.ts

elastic/security-engineering-productivity

  • x-pack/test/security_solution_cypress/config.ts

elastic/security-solution

  • x-pack/plugins/security_solution/common/experimental_features.ts
  • x-pack/plugins/security_solution/public/common/components/navigation/use_security_solution_navigation/index.tsx
  • x-pack/plugins/security_solution/public/threat_intelligence/links.ts
  • x-pack/plugins/security_solution/public/threat_intelligence/routes.tsx

elastic/security-threat-hunting-explore

  • x-pack/plugins/security_solution/public/common/components/navigation/use_security_solution_navigation/index.tsx

jamster10
jamster10 approved these changes Sep 23, 2022
View reviewed changes
Copy link
Contributor

@jamster10 jamster10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go for Explore changes

MadameSheema
MadameSheema approved these changes Sep 26, 2022
View reviewed changes
Copy link
Member

@MadameSheema MadameSheema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security-engineering-productivity changes LGTM

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 6.6MB 6.6MB -213.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolution 263.2KB 263.2KB -29.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@PhilippeOberti PhilippeOberti merged commit a352c76 into elastic:main Sep 26, 2022
@PhilippeOberti PhilippeOberti deleted the ti-feature-flag-removal branch September 26, 2022 14:12
@kibanamachine kibanamachine mentioned this pull request Sep 26, 2022
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 26, 2022
@PhilippeOberti
[TIP] Remove feature flag for Threat Intelligence plugin (elastic#141117
6c46097 
)

(cherry picked from commit a352c76)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.5

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Sep 26, 2022
@kibanamachine @PhilippeOberti
[TIP] Remove feature flag for Threat Intelligence plugin (#141117) (#…
8eaae01 
…141784)

(cherry picked from commit a352c76)

Co-authored-by: Philippe Oberti <[email protected]>
@maxcold maxcold added release_note:feature Makes this part of the condensed release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. and removed release_note:skip Skip the PR/issue when compiling release notes labels Sep 28, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@maxcold maxcold mentioned this pull request Sep 28, 2022
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamster10 jamster10 jamster10 approved these changes

@MadameSheema MadameSheema MadameSheema approved these changes

@lgestc lgestc lgestc approved these changes

@dhurley14 dhurley14 dhurley14 approved these changes

@maxcold maxcold maxcold approved these changes

Assignees
No one assigned
Labels
8.5 candidate release_note:feature Makes this part of the condensed release notes Team: Protections Experience Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.5.0 v8.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@PhilippeOberti @kibana-ci @kibanamachine @elasticmachine @maxcold @dhurley14 @lgestc @MadameSheema @jamster10