[TIP] Replace indicator field-selector EuiSelect by EuiComboBox #140980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilippeOberti
added
release_note:skip
lgestc
reviewed
Sep 20, 2022
| prepend={i18n.translate('xpack.threatIntelligence.indicator.fieldSelector.label', { | ||
| defaultMessage: 'Stack by', | ||
| })} | ||
| value={selectedField} | ||
| singleSelection={{ asPlainText: true }} | ||
| onChange={(event) => selectedFieldChange(event)} |
There was a problem hiding this comment.
onChange={selectedFieldChange} should be enough
lgestc
reviewed
Sep 20, 2022
| prepend={i18n.translate('xpack.threatIntelligence.indicator.fieldSelector.label', { | ||
| defaultMessage: 'Stack by', | ||
| })} | ||
| value={selectedField} | ||
| singleSelection={{ asPlainText: true }} |
There was a problem hiding this comment.
this object literal can be lifted outside the component scope, for perf.
lgestc
approved these changes
Sep 20, 2022
maxcold
approved these changes
Sep 20, 2022
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
kibanamachine
added
v8.5.0
backport:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The field selector next to the barchart on the Indicators page needed an update. The dropdown size was taking the whole screen and it wasn't searchable. To improve user experience, we're now using an EuiComboBox instead of an EuiSelect.
Screen.Recording.2022-09-19.at.10.34.19.AM.mov
https://github.com/elastic/security-team/issues/4628
and
https://github.com/elastic/security-team/issues/4749
Notes on the ACs: the height of the dropdown is now driven by the EuiCombobox component
Checklist
Delete any items that are not applicable to this PR.