Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't show spy panel with tsvb or timelion #14090

Merged
merged 2 commits into from
Oct 3, 2017
Merged

don't show spy panel with tsvb or timelion #14090

merged 2 commits into from
Oct 3, 2017

Conversation

ppisljar
Copy link
Member

Resolves #13570

@ppisljar ppisljar added Feature:Visualizations Generic visualization features (in case no more specific feature label is available) review labels Sep 21, 2017
thomasneirynck
thomasneirynck approved these changes Sep 25, 2017
View reviewed changes
Copy link
Contributor

@thomasneirynck thomasneirynck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mino imho, but for this use-case, would be a good candidate to change the showSpySpanel-boolean flag into a shouldShowSpyPanel() method. Following a method-call is easier than trying to figure out where a flag gets set.

@ppisljar ppisljar requested a review from nreese October 2, 2017 09:14
nreese
nreese reviewed Oct 2, 2017
View reviewed changes
Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @thomasneirynck's commit. Sounds like a good idea to move the login into a shouldShowSpyPanel() method

@ppisljar ppisljar merged commit 9be131e into elastic:master Oct 3, 2017
ppisljar added a commit that referenced this pull request Oct 3, 2017
@ppisljar
don't show spy panel with tsvb or timelion (#14090)
3973a54 
* don't show spy panel with tsvb or timelion

* adding shouldShowSpyPanel function
ppisljar added a commit that referenced this pull request Oct 3, 2017
@ppisljar
don't show spy panel with tsvb or timelion (#14090)
105201c 
* don't show spy panel with tsvb or timelion

* adding shouldShowSpyPanel function
@ppisljar
Copy link
Member Author

ppisljar commented Oct 3, 2017

backport:
6.x: 3973a54
6.0: 105201c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nreese nreese nreese left review comments

@thomasneirynck thomasneirynck thomasneirynck approved these changes

@simianhacker simianhacker Awaiting requested review from simianhacker

Assignees
No one assigned
Labels
Feature:Visualizations Generic visualization features (in case no more specific feature label is available) v6.0.0 v6.1.0 v7.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ppisljar @nreese @thomasneirynck