-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lens][Agg based table]Navigate to lens for agg based table vis #140791
[Lens][Agg based table]Navigate to lens for agg based table vis #140791
Conversation
…hub.com:Kunzetsov/kibana into navigate-to-lens-context-converting-imporvement
…hub.com:Kunzetsov/kibana into navigate-to-lens-context-converting-imporvement
…last_value.ts Co-authored-by: Marta Bondyra <[email protected]>
…ladLasitsa/kibana into navigate-to-lens-agg-based-vis
@elasticmachine merge upstream |
@elasticmachine merge upstream (to resolve ci issues caused by Github outage) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are two small inconsistencies that can be target later if at all:
- The histogram is not giving the same intervals as converted intervals:
- For the field types, it doesn't allow to convert for simple metric if used the not suppored fieldtype, like this one:
But for cumulative_sum of the same metric it allows to convert and then shows nice readable error message:
converts to:
I find neither of them critical so approving. It can be addressed later.
@mbondyra About that: we don't have possibility to provide interval for "intervals" in Lens. After discussion with Joe we decided to ignore interval for histogram. cc @flash1293 |
@mbondyra, we've fixed this problem. |
Rechecked, and re-approving! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The bundle size has been fixed, so I am dismissing my review
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Public APIs missing exports
Page load bundle
Unknown metric groupsAPI count
async chunk count
History
To update your PR or re-run it, just comment with: cc @VladLasitsa @Kunzetsov |
Summary
Completes part of #138236.
As part of phasing out TSVB and Visualize all Legacy agg based visulizations should support "open in lens" functionality.
In that PR converter for Agg based table was added.