Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing padding from the page header to the main content #140706

Merged
merged 7 commits into from
Sep 20, 2022
Merged

Fix missing padding from the page header to the main content #140706

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b77b160
Move styles to the index.scss file to avoid emotion css override
jennypavlova Sep 14, 2022
6b1d6f0
Merge branch 'main' into 140002-infrastructure-ui-missing-padding-fro…
jennypavlova Sep 14, 2022
b608db3
Merge branch 'main' into 140002-infrastructure-ui-missing-padding-fro…
jennypavlova Sep 14, 2022
acb7892
Use emotion css instead of scss
jennypavlova Sep 19, 2022
21031da
Merge branch 'main' into 140002-infrastructure-ui-missing-padding-fro…
jennypavlova Sep 19, 2022
82e4c8a
Merge branch 'main' into 140002-infrastructure-ui-missing-padding-fro…
jennypavlova Sep 19, 2022
4ccc436
Merge branch 'main' into 140002-infrastructure-ui-missing-padding-fro…
jennypavlova Sep 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions x-pack/plugins/infra/public/index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
// This is added to facilitate a full height layout whereby the
// inner container will set its own height and be scrollable.
.pageSectionContent {
display: flex;
flex-direction: column;
flex: 1 0 auto;
width: 100%;
height: 100%;
}
11 changes: 1 addition & 10 deletions x-pack/plugins/infra/public/pages/logs/stream/page_content.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
import { i18n } from '@kbn/i18n';
import React from 'react';
import { APP_WRAPPER_CLASS } from '@kbn/core/public';
import { css } from '@emotion/react';
import { LogSourceErrorPage } from '../../../components/logging/log_source_error_page';
import { SourceLoadingPage } from '../../../components/source_loading_page';
import { useLogViewContext } from '../../../hooks/use_log_view';
Expand Down Expand Up @@ -44,15 +43,7 @@ export const StreamPageContent: React.FunctionComponent = () => {
}}
pageSectionProps={{
contentProps: {
// This is added to facilitate a full height layout whereby the
// inner container will set its own height and be scrollable.
css: css`
display: flex;
flex-direction: column;
flex: 1 0 auto;
width: 100%;
height: 100%;
`,
className: 'pageSectionContent',
},
}}
>
Expand Down
12 changes: 1 addition & 11 deletions x-pack/plugins/infra/public/pages/metrics/hosts/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@

import { EuiErrorBoundary } from '@elastic/eui';
import { i18n } from '@kbn/i18n';
import { css } from '@emotion/react';
import React from 'react';
import { useTrackPageview } from '@kbn/observability-plugin/public';
import { APP_WRAPPER_CLASS } from '@kbn/core/public';
Expand Down Expand Up @@ -63,17 +62,8 @@ export const HostsPage = () => {
pageTitle: hostsTitle,
}}
pageSectionProps={{
paddingSize: 'none',
contentProps: {
// This is added to facilitate a full height layout whereby the
// inner container will set its own height and be scrollable.
css: css`
display: flex;
flex-direction: column;
flex: 1 0 auto;
width: 100%;
height: 100%;
`,
className: 'pageSectionContent',
},
}}
>
Expand Down
11 changes: 1 addition & 10 deletions x-pack/plugins/infra/public/pages/metrics/inventory_view/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
import { EuiErrorBoundary } from '@elastic/eui';
import { i18n } from '@kbn/i18n';
import React from 'react';
import { css } from '@emotion/react';
import { useTrackPageview } from '@kbn/observability-plugin/public';
import { APP_WRAPPER_CLASS } from '@kbn/core/public';
import { FilterBar } from './components/filter_bar';
Expand Down Expand Up @@ -77,15 +76,7 @@ export const SnapshotPage = () => {
}}
pageSectionProps={{
contentProps: {
// This is added to facilitate a full height layout whereby the
// inner container will set its own height and be scrollable.
css: css`
display: flex;
flex-direction: column;
flex: 1 0 auto;
width: 100%;
height: 100%;
`,
className: 'pageSectionContent',
},
}}
>
Expand Down