[visualization_editor] tabify visData before render

[spalger]

This fixes an error that sometimes is causing the tests to fail (it's a race) https://kibana-ci.elastic.co/job/elastic+kibana+6.x+multijob-intake/287/console

The error this prevents is here: http://github.com/elastic/kibana/blob/5c9ba5f73cc613e18689403819ee0a58f887b40c/src/core_plugins/table_vis/public/table_vis_controller.js#L32-L33

This line is executing after the test fails because the test completes after renderFunction is called and doesn't wait for rendering to complete (despite the test title).

@ppisljar can you take a look at how we can ensure that the vis tests are done rendering and cleaned up before moving on to the next tests?

[ppisljar]

if response should be tabified or not depends on the actual visualization the editor will render.
visualization defines responseHandler (which could be none, tabify or basic (does the point series/hierarchical stuff)

as the tests here are using table visualization tabify will work correctly.
maybe a better result would be to markdown, as it does not require any data, yet we would still be able to test visualize_editor

[ppisljar]

LGTM

[spalger]

how we can ensure that the vis tests are done rendering and cleaned up before moving on to the next tests?

Have any ideas @ppisljar?

[ppisljar]

@spalger wanna discuss this live ?

generally, rendercomplete will get called after rendering is done ... looking at the table code that should be the case ... so i am wondering if something else is going on ? do we get a renderComplete, but then render is called again or sth like this ?

[spalger]

6.0: 1be4e00
6.x/6.1: cc7e5a5