Cache all nested formatters #140480
Merged
Cache all nested formatters #140480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flash1293
added
Team:AppServicesSv
release_note:skip
💚 Build Succeeded
Metrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: |
|
Pinging @elastic/kibana-app-services (Team:AppServicesSv) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there are nested formatters within the agg formatters (like for range, date range or terms), it initializes a new formatter class for every call of the outer formatter. This is expensive and can quickly add up if there are a lot of data points:
This PR applies the performance optimization that was already applied to the multi field terms also to the others:
This reduces the runtime to roughly 1/20th of the original time, which matters for a lot of data points (the numbers above were obtained by rendering 47k data points with a terms formatter)