Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Response Ops] [Connectors] Move connectors type UI components to stack_connectors plugin #140444

Merged
merged 54 commits into from
Sep 27, 2022

Conversation

ymao1
Copy link
Contributor

@ymao1 ymao1 commented Sep 9, 2022

Towards #90931

Summary

Moved connector types UI code from triggers_actions_ui/public/built_in_action_types to new stack_connectors plugin.

Split connector types into stack and cases

  • stack types are .email, .index, .pagerduty, .server-log, .slack, .teams, .webhook
  • cases types are .cases-webhook, .jira, .resilient, .servicenow, .servicenow-sir, .servicenow-itom, .swimlane, .xmatters

Followup PRs to come for splitting out functional tests

To Verify

Ensure you can access the create connector form for each connector type in all the places in Kibana where you can create connectors. Also ensure that the action params forms work for connectors when adding actions to rules. I looked in the Stack Management > Rules and Connectors UI, the Stack Management > Cases UI, the Uptime Settings UI, the Security rule creation UI

ymao1 and others added 30 commits August 31, 2022 16:02
@ymao1 ymao1 added Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Actions/ConnectorTypes Issues related to specific Connector Types on the Actions Framework v8.6.0 labels Sep 22, 2022
@ymao1 ymao1 marked this pull request as ready for review September 22, 2022 15:08
@ymao1 ymao1 requested review from a team as code owners September 22, 2022 15:08
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@ymao1
Copy link
Contributor Author

ymao1 commented Sep 23, 2022

@elasticmachine merge upstream

@cnasikas
Copy link
Member

Hey @ymao1! The ServiceNow ITOM connector is not supported by cases. Should we move it to the stack connectors?

@ymao1
Copy link
Contributor Author

ymao1 commented Sep 23, 2022

Hey @ymao1! The ServiceNow ITOM connector is not supported by cases. Should we move it to the stack connectors?

@cnasikas Can we do that in a follow up PR? If I recall correctly, the server side code for all the servicenow connectors is pretty entertwined so I would prefer to uncouple that code in a separate PR if that's ok

@cnasikas
Copy link
Member

Of course!

@ymao1
Copy link
Contributor Author

ymao1 commented Sep 26, 2022

@elasticmachine merge upstream

Copy link
Contributor

@doakalexi doakalexi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I was able to create connectors in all the places mentioned.

Copy link
Contributor

@ersin-erdal ersin-erdal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested locally works as expected.

@ymao1
Copy link
Contributor Author

ymao1 commented Sep 27, 2022

@elasticmachine merge upstream

@ymao1
Copy link
Contributor Author

ymao1 commented Sep 27, 2022

@elasticmachine merge upstream

Copy link
Member

@pmuellr pmuellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whew! LGTM!

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
stackConnectors - 127 +127
triggersActionsUi 621 501 -120
total +7

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
triggersActionsUi 416 486 +70

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
stackConnectors - 324.6KB ⚠️ +324.6KB
triggersActionsUi 1.1MB 660.4KB -501.6KB
total -177.1KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
esUiShared 3 5 +2
triggersActionsUi 45 48 +3
total +5

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
stackConnectors - 20.8KB +20.8KB
triggersActionsUi 98.9KB 98.3KB -612.0B
total +20.2KB
Unknown metric groups

API count

id before after diff
triggersActionsUi 437 513 +76

async chunk count

id before after diff
stackConnectors - 48 +48
triggersActionsUi 98 49 -49
total -1

ESLint disabled line counts

id before after diff
stackConnectors 5 65 +60
triggersActionsUi 188 128 -60
total -0

Total ESLint disabled count

id before after diff
stackConnectors 9 69 +60
triggersActionsUi 191 131 -60
total -0

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @ymao1

@ymao1 ymao1 merged commit d41e5ab into elastic:main Sep 27, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Sep 27, 2022
@ymao1 ymao1 deleted the connector-types-plugin-ui branch September 27, 2022 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Actions/ConnectorTypes Issues related to specific Connector Types on the Actions Framework release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants