-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Response Ops] [Connectors] Move connectors type UI components to stack_connectors
plugin
#140444
Conversation
Pinging @elastic/response-ops (Team:ResponseOps) |
@elasticmachine merge upstream |
Hey @ymao1! The ServiceNow ITOM connector is not supported by cases. Should we move it to the stack connectors? |
@cnasikas Can we do that in a follow up PR? If I recall correctly, the server side code for all the servicenow connectors is pretty entertwined so I would prefer to uncouple that code in a separate PR if that's ok |
Of course! |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I was able to create connectors in all the places mentioned.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested locally works as expected.
@elasticmachine merge upstream |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whew! LGTM!
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Public APIs missing exports
Page load bundle
Unknown metric groupsAPI count
async chunk count
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @ymao1 |
Towards #90931
Summary
Moved connector types UI code from
triggers_actions_ui/public/built_in_action_types
to newstack_connectors
plugin.Split connector types into
stack
andcases
.email
,.index
,.pagerduty
,.server-log
,.slack
,.teams
,.webhook
.cases-webhook
,.jira
,.resilient
,.servicenow
,.servicenow-sir
,.servicenow-itom
,.swimlane
,.xmatters
Followup PRs to come for splitting out functional tests
To Verify
Ensure you can access the create connector form for each connector type in all the places in Kibana where you can create connectors. Also ensure that the action params forms work for connectors when adding actions to rules. I looked in the Stack Management > Rules and Connectors UI, the Stack Management > Cases UI, the Uptime Settings UI, the Security rule creation UI