-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SO Management: revert incorrect sorting on tags
column
#139999
SO Management: revert incorrect sorting on tags
column
#139999
Conversation
Pinging @elastic/kibana-core (Team:Core) |
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
) * SO Management: revert incorrect sorting on `tags` column * remove incorrect comment (cherry picked from commit 5c9a11a)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…140283) * SO Management: revert incorrect sorting on `tags` column * remove incorrect comment (cherry picked from commit 5c9a11a) Co-authored-by: Pierre Gayvallet <[email protected]>
Summary
Fix #138591
In short: Fix the incorrect sorting that was added to the SOM table's
tags
column in #132525In long: The
GetTableColumnDefinition
tagging API returns a column definition that is sortable by default. However this sorting logic only works for browser-side paginations:kibana/x-pack/plugins/saved_objects_tagging/public/ui_api/get_table_column_definition.tsx
Lines 37 to 43 in 6cfbb2f
#132525 added sorting to the SOM table, and, by doing that, enabled the sorting capability for the
tags
column. However when performing server-side paging, thesortable
logic of the column is just ignored, and the value of the column just sent to the server.Add to that that this
tags
column cannot be converted to a proper ES sort term, and we're forced to set the tags column back to non-sortable, which is what this PR does.