[TSVB][Lens] Navigate to Lens context converting improvement.

src/plugins/field_formats/common/mocks.ts

@@ -13,6 +13,7 @@ export const fieldFormatsMock: IFieldFormatsRegistry = {
   getByFieldType: jest.fn(),
   getDefaultConfig: jest.fn(),
   getDefaultInstance: jest.fn().mockImplementation(() => ({
+    type: { id: 'bytes' },
     convert: jest.fn().mockImplementation((t: string) => t),
     getConverterFor: jest.fn().mockImplementation(() => (t: string) => t),
   })),

src/plugins/vis_types/timeseries/common/agg_utils.ts

@@ -179,7 +179,7 @@ export const aggs: Agg[] = [
     },
   },
   {
-    id: TSVB_METRIC_TYPES.VALUE_COUNT,
+    id: METRIC_TYPES.VALUE_COUNT,
     meta: {
       ...aggDefaultMeta,
       isFilterRatioSupported: true,

src/plugins/vis_types/timeseries/common/enums/metric_types.ts

@@ -16,7 +16,6 @@ export enum TSVB_METRIC_TYPES {
   STD_DEVIATION = 'std_deviation',
   SUM_OF_SQUARES = 'sum_of_squares',
   TOP_HIT = 'top_hit',
-  VALUE_COUNT = 'value_count',
   VARIANCE = 'variance',
   CALCULATION = 'calculation',
   MOVING_AVERAGE = 'moving_average',

src/plugins/vis_types/timeseries/common/types/index.ts

@@ -11,7 +11,7 @@ import { KBN_FIELD_TYPES, Query } from '@kbn/data-plugin/common';
 import type { DataView } from '@kbn/data-views-plugin/public';
 import { Panel } from './panel_model';
 
-export type { Metric, Series, Panel, MetricType } from './panel_model';
+export type { Metric, Series, Panel, MetricType, Percentile } from './panel_model';
 export type {
   TimeseriesVisData,
   PanelData,

src/plugins/vis_types/timeseries/common/types/panel_model.ts

@@ -22,7 +22,7 @@ interface MetricVariable {
   name?: string;
 }
 
-interface Percentile {
+export interface Percentile {
   id: string;
   mode: 'line' | 'band';
   field?: string;

src/plugins/vis_types/timeseries/public/application/components/lib/get_supported_fields_by_metric_type.js

@@ -8,13 +8,12 @@
 
 import { KBN_FIELD_TYPES } from '@kbn/data-plugin/public';
 import { METRIC_TYPES } from '@kbn/data-plugin/common';
-import { TSVB_METRIC_TYPES } from '../../../../common/enums';
 
 export function getSupportedFieldsByMetricType(type) {
   switch (type) {
     case METRIC_TYPES.CARDINALITY:
       return Object.values(KBN_FIELD_TYPES).filter((t) => t !== KBN_FIELD_TYPES.HISTOGRAM);
-    case TSVB_METRIC_TYPES.VALUE_COUNT:
+    case METRIC_TYPES.VALUE_COUNT:
       return Object.values(KBN_FIELD_TYPES);
     case METRIC_TYPES.AVG:
     case METRIC_TYPES.SUM:

src/plugins/vis_types/timeseries/public/convert_to_lens/index.ts

@@ -11,9 +11,7 @@ import type { Panel } from '../../common/types';
 import { PANEL_TYPES } from '../../common/enums';
 import { ConvertTsvbToLensVisualization } from './types';
 
-const getConvertFnByType = (
-  type: PANEL_TYPES
-): Promise<ConvertTsvbToLensVisualization> | undefined => {
+const getConvertFnByType = (type: PANEL_TYPES) => {
   const convertionFns: { [key in PANEL_TYPES]?: () => Promise<ConvertTsvbToLensVisualization> } = {
     [PANEL_TYPES.TIMESERIES]: async () => {
       const { convertToLens } = await import('./timeseries');

src/plugins/vis_types/timeseries/public/convert_to_lens/lib/__mocks__/index.ts

@@ -0,0 +1,61 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License
+ * 2.0 and the Server Side Public License, v 1; you may not use this file except
+ * in compliance with, at your election, the Elastic License 2.0 or the Server
+ * Side Public License, v 1.
+ */
+
+import { PANEL_TYPES } from '../../../../common/enums';
+import { Panel, Series } from '../../../../common/types';
+
+export const createSeries = (partialSeries?: Partial<Series>): Series => ({
+  axis_position: 'right',
+  chart_type: 'line',
+  color: '#68BC00',
+  fill: '0.5',
+  formatter: '',
+  id: '3bb3c1d2-5af8-44cc-9759-86725e34b157',
+  label: '',
+  line_width: 1,
+  metrics: [],
+  override_index_pattern: 0,
+  palette: { name: 'default', type: 'palette' },
+  point_size: 1,
+  separate_axis: 0,
+  series_drop_last_bucket: 0,
+  split_mode: 'everything',
+  stacked: 'none',
+  time_range_mode: 'entire_time_range',
+  value_template: '{{value}}',
+  seperate_axis: 0,
+  series_index_pattern: { id: 'test' },
+  series_max_bars: 0,
+  steps: 0,
+  ...partialSeries,
+});
+
+export const createPanel = (parialPanel?: Partial<Panel>): Panel => ({
+  annotations: [],
+  axis_formatter: '',
+  axis_max: 100,
+  axis_min: 0,
+  axis_position: 'right',
+  axis_scale: '',
+  bar_color_rules: [],
+  drop_last_bucket: 0,
+  hide_last_value_indicator: false,
+  id: 'some-id',
+  ignore_daylight_time: true,
+  index_pattern: { id: 'test' },
+  interval: '',
+  // eslint-disable-next-line @typescript-eslint/naming-convention
+  markdown_openLinksInNewTab: 0,
+  markdown_scrollbars: 0,
+  max_bars: 0,
+  series: [createSeries()],
+  show_grid: 0,
+  show_legend: 0,
+  type: PANEL_TYPES.TIMESERIES,
+  ...parialPanel,
+});

src/plugins/vis_types/timeseries/public/convert_to_lens/lib/layers/index.ts → src/plugins/vis_types/timeseries/public/convert_to_lens/lib/configurations/index.ts

@@ -6,4 +6,4 @@
  * Side Public License, v 1.
  */
 
-export * from './get_layer';
+export * from './xy';

src/plugins/vis_types/timeseries/public/convert_to_lens/lib/configurations/xy/chart_type.ts

@@ -0,0 +1,41 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License
+ * 2.0 and the Server Side Public License, v 1; you may not use this file except
+ * in compliance with, at your election, the Elastic License 2.0 or the Server
+ * Side Public License, v 1.
+ */
+
+import { SeriesType, SeriesTypes } from '@kbn/visualizations-plugin/common/convert_to_lens';
+import { Series } from '../../../../../common/types';
+import { PANEL_TYPES } from '../../../../../common/enums';
+
+export const getChartType = (series: Series, type: PANEL_TYPES): SeriesType => {
+  let layerChartType: SeriesType = SeriesTypes.LINE;
+  switch (series.chart_type) {
+    case SeriesTypes.LINE:
+      layerChartType = Number(series.fill) > 0 ? SeriesTypes.AREA : SeriesTypes.LINE;
+      break;
+    case SeriesTypes.AREA:
+      layerChartType = SeriesTypes.AREA;
+      break;
+    case SeriesTypes.BAR:
+      layerChartType = SeriesTypes.BAR;
+      break;
+  }
+
+  if (type === PANEL_TYPES.TOP_N) {
+    return SeriesTypes.BAR_HORIZONTAL;
+  }
+
+  if (series.stacked !== 'none' && series.stacked !== 'percent') {
+    return layerChartType !== SeriesTypes.LINE ? `${layerChartType}_stacked` : SeriesTypes.LINE;
+  }
+  if (series.stacked === 'percent') {
+    return layerChartType !== SeriesTypes.LINE
+      ? `${layerChartType}_percentage_stacked`
+      : SeriesTypes.LINE;
+  }
+
+  return layerChartType;
+};

src/plugins/vis_types/timeseries/public/convert_to_lens/lib/configurations/xy/configuration.test.ts

@@ -0,0 +1,67 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License
+ * 2.0 and the Server Side Public License, v 1; you may not use this file except
+ * in compliance with, at your election, the Elastic License 2.0 or the Server
+ * Side Public License, v 1.
+ */
+
+import { createPanel } from '../../__mocks__';
+import { getConfigurationForTopN, getConfigurationForTimeseries } from './configuration';
+
+describe('getConfigurationForTimeseries', () => {
+  test('should return correct configuration for timeseries', () => {
+    expect(getConfigurationForTimeseries(createPanel(), [])).toEqual({
+      layers: [],
+      fillOpacity: 0.5,
+      legend: {
+        isVisible: false,
+        showSingleSeries: false,
+        position: 'right',
+        shouldTruncate: false,
+        maxLines: 1,
+      },
+      gridlinesVisibilitySettings: {
+        x: false,
+        yLeft: false,
+        yRight: false,
+      },
+      yLeftExtent: { mode: 'full' },
+      yRightExtent: { mode: 'full' },
+      yLeftScale: 'linear',
+      yRightScale: 'linear',
+    });
+  });
+});
+
+describe('getConfigurationForTopN', () => {
+  test('should return correct configuration for top n', () => {
+    expect(getConfigurationForTopN(createPanel(), [])).toEqual({
+      layers: [],
+      fillOpacity: 0.5,
+      legend: {
+        isVisible: false,
+        showSingleSeries: false,
+        position: 'right',
+        shouldTruncate: false,
+        maxLines: 1,
+      },
+      gridlinesVisibilitySettings: {
+        x: false,
+        yLeft: false,
+        yRight: false,
+      },
+      tickLabelsVisibilitySettings: {
+        x: true,
+        yLeft: false,
+        yRight: false,
+      },
+      axisTitlesVisibilitySettings: {
+        x: false,
+        yLeft: false,
+        yRight: false,
+      },
+      valueLabels: 'show',
+    });
+  });
+});

src/plugins/vis_types/timeseries/public/convert_to_lens/lib/configurations/xy/configuration.ts

@@ -0,0 +1,70 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License
+ * 2.0 and the Server Side Public License, v 1; you may not use this file except
+ * in compliance with, at your election, the Elastic License 2.0 or the Server
+ * Side Public License, v 1.
+ */
+
+import { Position } from '@elastic/charts';
+import { XYConfiguration, XYLayerConfig } from '@kbn/visualizations-plugin/common';
+import { Panel } from '../../../../../common/types';
+import { getYExtents } from './extents';
+
+export const getConfigurationForTimeseries = (
+  model: Panel,
+  layers: XYLayerConfig[]
+): XYConfiguration => {
+  const extents = getYExtents(model);
+  return {
+    layers,
+    fillOpacity: Number(model.series[0].fill) ?? 0.3,
+    legend: {
+      isVisible: Boolean(model.show_legend),
+      showSingleSeries: Boolean(model.show_legend),
+      position: (model.legend_position as Position) ?? Position.Right,
+      shouldTruncate: Boolean(model.truncate_legend),
+      maxLines: model.max_lines_legend ?? 1,
+    },
+    gridlinesVisibilitySettings: {
+      x: Boolean(model.show_grid),
+      yLeft: Boolean(model.show_grid),
+      yRight: Boolean(model.show_grid),
+    },
+    yLeftExtent: extents.yLeftExtent,
+    yRightExtent: extents.yRightExtent,
+    yLeftScale: model.axis_scale === 'log' ? 'log' : 'linear',
+    yRightScale: model.axis_scale === 'log' ? 'log' : 'linear',
+  };
+};
+
+export const getConfigurationForTopN = (
+  model: Panel,
+  layers: XYLayerConfig[]
+): XYConfiguration => ({
+  layers,
+  fillOpacity: Number(model.series[0].fill) ?? 0.3,
+  legend: {
+    isVisible: Boolean(model.show_legend),
+    showSingleSeries: Boolean(model.show_legend),
+    position: (model.legend_position as Position) ?? Position.Right,
+    shouldTruncate: Boolean(model.truncate_legend),
+    maxLines: model.max_lines_legend ?? 1,
+  },
+  gridlinesVisibilitySettings: {
+    x: false,
+    yLeft: false,
+    yRight: false,
+  },
+  tickLabelsVisibilitySettings: {
+    x: true,
+    yLeft: false,
+    yRight: false,
+  },
+  axisTitlesVisibilitySettings: {
+    x: false,
+    yLeft: false,
+    yRight: false,
+  },
+  valueLabels: 'show',
+});

src/plugins/vis_types/timeseries/public/convert_to_lens/lib/xy/extents.test.ts → src/plugins/vis_types/timeseries/public/convert_to_lens/lib/configurations/xy/extents.test.ts

@@ -5,7 +5,7 @@
  * in compliance with, at your election, the Elastic License 2.0 or the Server
  * Side Public License, v 1.
  */
-import type { Panel } from '../../../../common/types';
+import type { Panel } from '../../../../../common/types';
 import { getYExtents } from './extents';
 
 const model = {

src/plugins/vis_types/timeseries/public/convert_to_lens/lib/xy/extents.ts → src/plugins/vis_types/timeseries/public/convert_to_lens/lib/configurations/xy/extents.ts

@@ -6,7 +6,8 @@
  * Side Public License, v 1.
  */
 
-import type { Panel, Series } from '../../../../common/types';
+import { AxisExtentConfig } from '@kbn/visualizations-plugin/common/convert_to_lens';
+import type { Panel, Series } from '../../../../../common/types';
 
 const lowerBoundShouldBeZero = (
   lowerBound: number | null,
@@ -45,7 +46,12 @@ const getLowerValue = (
  * In Lens, we only allow 2 axis, one left and one right. We need an assumption here.
  * We will transfer in Lens the  "collapsed" axes with both bounds.
  */
-export const getYExtents = (model: Panel) => {
+export const getYExtents = (
+  model: Panel
+): {
+  yLeftExtent?: AxisExtentConfig;
+  yRightExtent?: AxisExtentConfig;
+} => {
   let lowerBoundLeft: number | null = null;
   let upperBoundLeft: number | null = null;
   let lowerBoundRight: number | null = null;

src/plugins/vis_types/timeseries/public/convert_to_lens/lib/xy/index.ts → src/plugins/vis_types/timeseries/public/convert_to_lens/lib/configurations/xy/index.ts

@@ -6,5 +6,7 @@
  * Side Public License, v 1.
  */
 
+export * from './layers';
 export * from './extents';
 export * from './chart_type';
+export * from './configuration';