Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIP] Preserve indicator grid state #139696

Merged
merged 1 commit into from
Sep 1, 2022
Merged

[TIP] Preserve indicator grid state #139696

merged 1 commit into from
Sep 1, 2022

Conversation

lgestc
Copy link
Contributor

@lgestc lgestc commented Aug 30, 2022

Summary

This PR saves and restores whatever changes the user might have made into column display into local storage.
This does not include sorting yet, as we have not implemented that part so far.

This should resolve the following: https://github.com/elastic/security-team/issues/4534

Checklist

Delete any items that are not applicable to this PR.

@lgestc lgestc added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting 8.5 candidate labels Aug 30, 2022
@lgestc lgestc requested a review from a team as a code owner August 30, 2022 10:20
PhilippeOberti
PhilippeOberti approved these changes Sep 1, 2022
View reviewed changes
Copy link
Contributor

@PhilippeOberti PhilippeOberti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome!

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
threatIntelligence 133 135 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
threatIntelligence 63.4KB 64.2KB +862.0B

History

  • 💚 Build #68239 succeeded e8a5885aa6ea3e1cab3d48a191ed5a1df3504ecf

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@lgestc lgestc merged commit 6e55a40 into elastic:main Sep 1, 2022
@lgestc lgestc deleted the preserve-grid-state branch September 1, 2022 13:27
jbudz added a commit that referenced this pull request Sep 1, 2022
@jbudz
fix snapshot conflict between #139814 and #139696
d83720f
Mpdreamz pushed a commit to Mpdreamz/kibana that referenced this pull request Sep 6, 2022
@lgmys @Mpdreamz
[TIP] Preserve the state of IoC data grid for a user (elastic#139696)
303e285
Mpdreamz pushed a commit to Mpdreamz/kibana that referenced this pull request Sep 6, 2022
@jbudz @Mpdreamz
fix snapshot conflict between elastic#139814 and elastic#139696
f7fceb6
@maxcold maxcold mentioned this pull request Sep 27, 2022
Closed
2 tasks
@maxcold maxcold added release_note:enhancement Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. and removed release_note:skip Skip the PR/issue when compiling release notes labels Sep 28, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilippeOberti PhilippeOberti PhilippeOberti approved these changes

@maxcold maxcold Awaiting requested review from maxcold

Assignees
No one assigned
Labels
8.5 candidate backport:skip This commit does not require backporting release_note:enhancement Team: Protections Experience Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lgestc @kibana-ci @elasticmachine @PhilippeOberti @maxcold @kibanamachine