Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] [Spacetime] Refactoring Fleet Cypress tests #139693

Merged
merged 25 commits into from
Sep 7, 2022
Merged

[Fleet] [Spacetime] Refactoring Fleet Cypress tests #139693

merged 25 commits into from
Sep 7, 2022

Conversation

criamico
Copy link
Contributor

@criamico criamico commented Aug 30, 2022 •
edited
Loading

Summary

Closes https://github.com/elastic/ingest-dev/issues/1200

Fixes #137094

Also some improvements based on #121436

Spacetime work:

  • Improve and re-enable skipped specs
  • Add and reorganise missing selectors; some failures were caused by wrong or ambiguous selectors, so I made an effort to replace them with unique ones, declared as global constants
  • Add a basic spec about enrollment tokens page

@criamico criamico self-assigned this Aug 30, 2022
@criamico criamico added Team:Fleet Team label for Observability Data Collection Fleet team release_note:skip Skip the PR/issue when compiling release notes labels Aug 30, 2022
@criamico
Copy link
Contributor Author

@elasticmachine merge upstream

@criamico
Copy link
Contributor Author

@elasticmachine merge upstream

@criamico
Copy link
Contributor Author

criamico commented Sep 5, 2022

@elasticmachine merge upstream

@criamico
Copy link
Contributor Author

criamico commented Sep 6, 2022

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 865.3KB 865.8KB +590.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @criamico

@criamico criamico marked this pull request as ready for review September 6, 2022 12:41
@criamico criamico requested a review from a team as a code owner September 6, 2022 12:41
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

nchaulet
nchaulet approved these changes Sep 6, 2022
View reviewed changes
Copy link
Member

@nchaulet nchaulet left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me 🚀 Thanks for giving some love to these tests!

@criamico criamico merged commit a5a4884 into elastic:main Sep 7, 2022
@criamico criamico deleted the spacetime/fleet_cypress_specs branch September 7, 2022 08:31
@kibanamachine kibanamachine added v8.5.0 backport:skip This commit does not require backporting labels Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nchaulet nchaulet nchaulet approved these changes

Assignees

@criamico criamico

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Fleet] Reenable skipped cypress test integrations_real
5 participants
@criamico @kibana-ci @elasticmachine @nchaulet @kibanamachine