[Fleet] Show equivalent API requests #139658

nchaulet · 2022-08-29T17:42:14Z

Summary

That PR add a new experimental feature to Fleet to show equivalent API request to some UI actions, this can be enabled by adding the following to your Kibana config file, the feature is enabled by default but it will be easy to revert if we do not want to ship it.

We use the shared component ViewApiRequestFlyout (used by stack management) to show the request, this allow to copy the requests and open them in the devtools, it's similar from what it's done in the stack managment plugin see bellow

UI Changes

This is the same for create/edit agent policy and package policy

nchaulet · 2022-08-30T14:43:54Z

@dborodyansky I am curious to have your thoughts on the bottom bar with an extra button

dborodyansky · 2022-08-30T15:53:32Z

Thanks @nchaulet. Is there a document where I can learn more about the product value and rationale for this feature? I'd like to understand the context around UI proximity to the main action on these screens vs. somewhere more subtle if this action is experimental and less anticipated.

On a minor note, we might consider "View API requests" or "Preview API requests" for the label (cc: @dedemorton). Also, spacing around the new button looks a bit tight. Happy to meet and chat about this.

nchaulet · 2022-08-30T16:00:40Z

Thanks @nchaulet. Is there a document where I can learn more about the product value and rationale for this feature? I'd like to understand the context around UI proximity to the main action on these screens vs. somewhere more subtle if this action is experimental and less anticipated.

No there is no document about that, I am working on that as part of ON week and experimenting with this, I think it could be a good addition in our effort to making Fleet APIs ready for beta #123150

…how-devtools-request

elasticmachine · 2022-09-13T19:37:32Z

Pinging @elastic/fleet (Team:Fleet)

nchaulet · 2022-09-13T19:39:12Z

x-pack/plugins/fleet/common/errors.ts

+
+import { FleetErrorType } from './types';
+
+export class IngestManagerError extends Error {


I add to move a server side service here, I think it make sense to have errors define here no?

…-fix'

…how-devtools-request

juliaElastic · 2022-09-15T12:48:47Z

x-pack/plugins/fleet/common/errors.ts

+
+import type { FleetErrorType } from './types';
+
+export class IngestManagerError extends Error {


it would be great to rename this error to FleetError, though that might touch many files

I will try to come with a separate PR for that (just after that one to avoid conflict) but with typescript this should be pretty easy to rename :)

...t/public/applications/fleet/sections/agent_policy/details_page/components/settings/index.tsx

...ins/fleet/public/applications/fleet/sections/agent_policy/edit_package_policy_page/index.tsx

...public/applications/fleet/sections/agent_policy/list_page/components/create_agent_policy.tsx

juliaElastic

LGTM, added a few nits on wording.

…how-devtools-request

nchaulet · 2022-09-15T14:52:48Z

@elasticmachine merge upstream

kibana-ci · 2022-09-15T16:15:45Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: 0bf9a37

Failed CI Steps

Test Failures

[job] [logs] FTR Configs #48 / alerting api integration security and spaces enabled Alerts - Group 1 alerts disable space_1_all_with_restricted_fixture at space1 should still be able to disable alert when AAD is broken
[job] [logs] FTR Configs #13 / endpoint Response Actions Responder from timeline "before all" hook for "should show Responder from alert in a timeline"

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`fleet`	722	728	+6

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`fleet`	879.8KB	884.1KB	+4.3KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`fleet`	107.4KB	107.5KB	+95.0B

Unknown metric groups

ESLint disabled in files

id	before	after	diff
`fleet`	7	8	+1

Total ESLint disabled count

id	before	after	diff
`fleet`	68	69	+1

History

💔 Build #72712 failed 37da522
💚 Build #71989 succeeded e74fd34
💔 Build #71969 failed 9b4aa06
💔 Build #71957 failed 823f3a4
💔 Build #71934 failed 24a45a4

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @nchaulet

ghost · 2022-09-27T05:53:40Z

Hi Team

We have validated this feature on latest 8.5 BC1 Kibana cloud environment and found it working fine.

Build Details:
BUILD: 56595
COMMIT: 0d8de4d

Further we have created 05 testcases for this feature after reviewing under our Fleet Test plan.

Thanks

ghost · 2022-10-04T09:36:21Z

Hi Team,

We have executed 05 testcases for this feature under our Fleet Test run at Fleet 8.5.0-BC2 Feature test plan and found that it's working fine.

Build details:

Version: 8.5.0 BC2
Build: 56806
Commit: dc769f45a5a6dafb0a8c8f0c0cabcced4df45e11

Hence, marking this as QA:Validated.
Thanks!

nchaulet added release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team labels Aug 29, 2022

nchaulet self-assigned this Aug 29, 2022

nchaulet added the ci:no-auto-commit Disable auto-committing changes on CI label Aug 29, 2022

nchaulet force-pushed the feature-fleet-show-devtools-request branch 3 times, most recently from e4b66f3 to 7ed62d4 Compare August 30, 2022 14:28

[Fleet] Show equivalent API requests

33804e8

nchaulet force-pushed the feature-fleet-show-devtools-request branch from 7ed62d4 to 33804e8 Compare August 30, 2022 15:38

nchaulet added 3 commits September 13, 2022 14:27

Merge branch 'main' of github.com:elastic/kibana into feature-fleet-s…

ccdae69

…how-devtools-request

Update copy and Add beta

fb19d50

Fix copy

24a45a4

nchaulet marked this pull request as ready for review September 13, 2022 19:37

nchaulet requested a review from a team as a code owner September 13, 2022 19:37

nchaulet requested a review from kpollich September 13, 2022 19:38

nchaulet commented Sep 13, 2022

View reviewed changes

nchaulet mentioned this pull request Sep 13, 2022

[Request][Fleet] Document agent policy/package policy API elastic/observability-docs#2180

Closed

nchaulet added v8.5.0 and removed ci:no-auto-commit Disable auto-committing changes on CI labels Sep 13, 2022

nchaulet and others added 6 commits September 13, 2022 16:12

remove unused imports

40691f9

[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…

823f3a4

…-fix'

Fix linting

9b4aa06

Fix linting

d87a60b

Merge branch 'main' of github.com:elastic/kibana into feature-fleet-s…

b409599

…how-devtools-request

Fix tests

e74fd34

nchaulet mentioned this pull request Sep 14, 2022

[Fleet] Human readable documentation for integration inputs & streams #139045

Merged

juliaElastic reviewed Sep 15, 2022

View reviewed changes

...t/public/applications/fleet/sections/agent_policy/details_page/components/settings/index.tsx Outdated Show resolved Hide resolved

juliaElastic reviewed Sep 15, 2022

View reviewed changes

...ins/fleet/public/applications/fleet/sections/agent_policy/edit_package_policy_page/index.tsx Outdated Show resolved Hide resolved

juliaElastic reviewed Sep 15, 2022

View reviewed changes

...public/applications/fleet/sections/agent_policy/list_page/components/create_agent_policy.tsx Outdated Show resolved Hide resolved

juliaElastic approved these changes Sep 15, 2022

View reviewed changes

nchaulet added 2 commits September 15, 2022 09:39

Fix after review

99c43ed

Merge branch 'main' of github.com:elastic/kibana into feature-fleet-s…

37da522

…how-devtools-request

nchaulet enabled auto-merge (squash) September 15, 2022 14:40

Merge branch 'main' into feature-fleet-show-devtools-request

0bf9a37

nchaulet merged commit 6e6b10a into elastic:main Sep 15, 2022

kibanamachine added the backport:skip This commit does not require backporting label Sep 15, 2022

joshdover added the QA:Needs Validation Issue needs to be validated by QA label Sep 21, 2022

ghost added QA:Validated Issue has been validated by QA QA:Needs Validation Issue needs to be validated by QA and removed QA:Needs Validation Issue needs to be validated by QA QA:Validated Issue has been validated by QA labels Sep 27, 2022

ghost added QA:Validated Issue has been validated by QA and removed QA:Needs Validation Issue needs to be validated by QA labels Oct 4, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Fleet] Show equivalent API requests #139658

[Fleet] Show equivalent API requests #139658

nchaulet commented Aug 29, 2022 •

edited

Loading

nchaulet commented Aug 30, 2022

dborodyansky commented Aug 30, 2022

nchaulet commented Aug 30, 2022

elasticmachine commented Sep 13, 2022

nchaulet Sep 13, 2022

juliaElastic Sep 15, 2022

nchaulet Sep 15, 2022

juliaElastic left a comment

nchaulet commented Sep 15, 2022

kibana-ci commented Sep 15, 2022

ESLint disabled in files

Total ESLint disabled count

ghost commented Sep 27, 2022 •

edited by ghost

Loading

ghost commented Oct 4, 2022


		import { FleetErrorType } from './types';

		export class IngestManagerError extends Error {


		import type { FleetErrorType } from './types';

		export class IngestManagerError extends Error {

[Fleet] Show equivalent API requests #139658

[Fleet] Show equivalent API requests #139658

Conversation

nchaulet commented Aug 29, 2022 • edited Loading

Summary

UI Changes

nchaulet commented Aug 30, 2022

dborodyansky commented Aug 30, 2022

nchaulet commented Aug 30, 2022

elasticmachine commented Sep 13, 2022

nchaulet Sep 13, 2022

Choose a reason for hiding this comment

juliaElastic Sep 15, 2022

Choose a reason for hiding this comment

nchaulet Sep 15, 2022

Choose a reason for hiding this comment

juliaElastic left a comment

Choose a reason for hiding this comment

nchaulet commented Sep 15, 2022

kibana-ci commented Sep 15, 2022

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

Module Count

Async chunks

Page load bundle

ESLint disabled in files

Total ESLint disabled count

History

ghost commented Sep 27, 2022 • edited by ghost Loading

ghost commented Oct 4, 2022

nchaulet commented Aug 29, 2022 •

edited

Loading

ghost commented Sep 27, 2022 •

edited by ghost

Loading