Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Shared UX] Migrate avatar user profile component from packages/kbn-user-profile-components to Shared UX #139247

Merged
merged 37 commits into from
Sep 19, 2022

Conversation

rshen91
Copy link
Contributor

@rshen91 rshen91 commented Aug 22, 2022

Summary

This PR migrates the avatar work into the shared UX realm.

In Future PRs:

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@rshen91 rshen91 added Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) release_note:skip Skip the PR/issue when compiling release notes labels Sep 6, 2022
@rshen91 rshen91 marked this pull request as ready for review September 6, 2022 17:38
@rshen91 rshen91 requested a review from a team September 6, 2022 17:38
@rshen91 rshen91 requested a review from majagrubic September 8, 2022 13:13
Copy link
Contributor

@majagrubic majagrubic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not finish reviewing, just leaving some comments for now

Copy link
Contributor

@majagrubic majagrubic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in Chrome on Mac OSX in storybook, works nicely. Left a few comments, but mostly nits.

searchProps={{
placeholder:
searchPlaceholder ??
i18n.translate(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be a constant?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dig it - 702fb2e for updates

/>
)}
</EuiButtonEmpty>
) : undefined}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: should be null

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice good catch 702fb2e

@rshen91 rshen91 enabled auto-merge (squash) September 19, 2022 17:33
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/shared-ux-avatar-user-profile-components - 3 +3
Unknown metric groups

API count

id before after diff
@kbn/shared-ux-avatar-user-profile-components - 40 +40

ESLint disabled line counts

id before after diff
@kbn/shared-ux-avatar-user-profile-components - 2 +2

Total ESLint disabled count

id before after diff
@kbn/shared-ux-avatar-user-profile-components - 2 +2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @rshen91

@rshen91 rshen91 merged commit 7734761 into elastic:main Sep 19, 2022
@kibanamachine kibanamachine added v8.5.0 backport:skip This commit does not require backporting labels Sep 19, 2022
@rshen91 rshen91 deleted the migrate-avatars branch September 20, 2022 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) v8.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants