-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[8.5][Elastic Defend onboarding] Endpoint and Cloud settings #139230
[8.5][Elastic Defend onboarding] Endpoint and Cloud settings #139230
Conversation
...management/pages/policy/view/ingest_manager_integration/endpoint_policy_create_extension.tsx
Outdated
Show resolved
Hide resolved
...management/pages/policy/view/ingest_manager_integration/endpoint_policy_create_extension.tsx
Outdated
Show resolved
Hide resolved
...management/pages/policy/view/ingest_manager_integration/endpoint_policy_create_extension.tsx
Outdated
Show resolved
Hide resolved
...management/pages/policy/view/ingest_manager_integration/endpoint_policy_create_extension.tsx
Outdated
Show resolved
Hide resolved
...management/pages/policy/view/ingest_manager_integration/endpoint_policy_create_extension.tsx
Outdated
Show resolved
Hide resolved
...management/pages/policy/view/ingest_manager_integration/endpoint_policy_create_extension.tsx
Outdated
Show resolved
Hide resolved
...management/pages/policy/view/ingest_manager_integration/endpoint_policy_create_extension.tsx
Outdated
Show resolved
Hide resolved
...management/pages/policy/view/ingest_manager_integration/endpoint_policy_create_extension.tsx
Outdated
Show resolved
Hide resolved
...management/pages/policy/view/ingest_manager_integration/endpoint_policy_create_extension.tsx
Outdated
Show resolved
Hide resolved
...management/pages/policy/view/ingest_manager_integration/endpoint_policy_create_extension.tsx
Outdated
Show resolved
Hide resolved
...management/pages/policy/view/ingest_manager_integration/endpoint_policy_create_extension.tsx
Outdated
Show resolved
Hide resolved
...management/pages/policy/view/ingest_manager_integration/endpoint_policy_create_extension.tsx
Outdated
Show resolved
Hide resolved
...management/pages/policy/view/ingest_manager_integration/endpoint_policy_create_extension.tsx
Outdated
Show resolved
Hide resolved
...management/pages/policy/view/ingest_manager_integration/endpoint_policy_create_extension.tsx
Outdated
Show resolved
Hide resolved
...management/pages/policy/view/ingest_manager_integration/endpoint_policy_create_extension.tsx
Outdated
Show resolved
Hide resolved
...management/pages/policy/view/ingest_manager_integration/endpoint_policy_create_extension.tsx
Outdated
Show resolved
Hide resolved
padding-bottom: 14px; | ||
`; | ||
|
||
const dropDownOptions = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you make this read only? or use `Object.freeze() on the array.
also, can you add a type to it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@paul-tavares - thanks for all the tips on the first PR review round. I just pushed a code refactoring that addresses most of the suggestions, plus some optimizations on the logic, so I'll ask you to review it one more time, but I'm unsure if this one is still needed now that I have added the mappings.
...management/pages/policy/view/ingest_manager_integration/endpoint_policy_create_extension.tsx
Outdated
Show resolved
Hide resolved
...management/pages/policy/view/ingest_manager_integration/endpoint_policy_create_extension.tsx
Outdated
Show resolved
Hide resolved
...management/pages/policy/view/ingest_manager_integration/endpoint_policy_create_extension.tsx
Outdated
Show resolved
Hide resolved
...management/pages/policy/view/ingest_manager_integration/endpoint_policy_create_extension.tsx
Outdated
Show resolved
Hide resolved
...management/pages/policy/view/ingest_manager_integration/endpoint_policy_create_extension.tsx
Outdated
Show resolved
Hide resolved
...management/pages/policy/view/ingest_manager_integration/endpoint_policy_create_extension.tsx
Outdated
Show resolved
Hide resolved
I have some suggestions for the UI copy, assuming the screenshots at the top of the PR are still current:
|
Thanks for the suggestions @benironside! Edit: updated the PR with the suggestions |
…IChange refactoring ui component
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all of the changes. It's looking good.
My only concern is the disabling of the ESLint for the react useEffect()
hooks. Can we remove those? I can help if needed - let me know.
...st_manager_integration/endpoint_policy_create_extension/endpoint_policy_create_extension.tsx
Outdated
Show resolved
Hide resolved
...st_manager_integration/endpoint_policy_create_extension/endpoint_policy_create_extension.tsx
Outdated
Show resolved
Hide resolved
…IChange adding useCallbacks and memoization, fixing deps list
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks for all the changes.
@opauloh @animehart - just a heads up, this PR skips the flakey test, so make sure you've this in and your PR should pass. One of our PRs was having the same issue. |
thanks a lot @kevinlog |
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @opauloh |
Summary
We are going to introduce new fields on the Endpoint and Cloud Security integration onboarding page. The primary objective is to offer the user optimized options for Endpoint usage versus Cloud Security usage, which involves enabling some of the fields that are only available on the Edit Integration page (like session_data and preventions), plus adding options for data retention that will be sent to the backend to create an Event Filter based on the user's choice of data retention.
Changes:
Screenshots (Click on the Image to see it larger)
Settings for Endpoint
NGAV
-- Malware: Prevent
-- Ransomware: Prevent
-- Memory Protection: Prevent
-- Event Collection: Process Only
EDR Essential
-- Malware: Prevent
-- Ransomware: Prevent
-- Memory Protection: Prevent
-- Event Collection: Process, Network, File
EDR Complete
-- Malware: Prevent
-- Ransomware: Prevent
-- Memory Protection: Prevent
-- Event Collection: Process, Network, File + Session Data