Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.5][Elastic Defend onboarding] Endpoint and Cloud settings #139230

Merged

Conversation

animehart
Copy link
Contributor

@animehart animehart commented Aug 22, 2022

Summary

We are going to introduce new fields on the Endpoint and Cloud Security integration onboarding page. The primary objective is to offer the user optimized options for Endpoint usage versus Cloud Security usage, which involves enabling some of the fields that are only available on the Edit Integration page (like session_data and preventions), plus adding options for data retention that will be sent to the backend to create an Event Filter based on the user's choice of data retention.

Changes:

  • Added Options to choose between Endpoint Security and Cloud Security
  • Added More sub-options under the options above
  • Disabled malware protections for Cloud security due to performance issues.

Screenshots (Click on the Image to see it larger)

Current New (Endpoint selected) New (Cloud Security selected)

Settings for Endpoint

NGAV
-- Malware: Prevent
-- Ransomware: Prevent
-- Memory Protection: Prevent
-- Event Collection: Process Only

EDR Essential
-- Malware: Prevent
-- Ransomware: Prevent
-- Memory Protection: Prevent
-- Event Collection: Process, Network, File

EDR Complete
-- Malware: Prevent
-- Ransomware: Prevent
-- Memory Protection: Prevent
-- Event Collection: Process, Network, File + Session Data

@nastasha-solomon nastasha-solomon added the ui-copy Review of UI copy with docs team is recommended label Aug 25, 2022
@benironside benironside self-requested a review August 25, 2022 20:24
@opauloh opauloh added the Team: AWP: Visualization AWP team that does most fullstack work in kibana label Aug 26, 2022
padding-bottom: 14px;
`;

const dropDownOptions = [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you make this read only? or use `Object.freeze() on the array.

also, can you add a type to it.

Copy link
Contributor

@opauloh opauloh Sep 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paul-tavares - thanks for all the tips on the first PR review round. I just pushed a code refactoring that addresses most of the suggestions, plus some optimizations on the logic, so I'll ask you to review it one more time, but I'm unsure if this one is still needed now that I have added the mappings.

@paul-tavares paul-tavares requested review from dasansol92 and removed request for ashokaditya September 19, 2022 20:56
@opauloh opauloh self-assigned this Sep 19, 2022
@benironside
Copy link
Contributor

I have some suggestions for the UI copy, assuming the screenshots at the top of the PR are still current:

  • Instead of “You can make changes to the configurations after you add it.” -> “You can make configuration changes after you create the integration.”

  • Instead of “Select for what environment you would like to add the integration” -> “Select the type of environment you want to protect”

  • Instead of “To save on data ingestion volume select interactive session only” -> “To reduce data ingestion volume, select Interactive only”

  • Instead of “You can disable detections anytime in the agent policy configurations settings.” -> “You can disable protections anytime in the agent policy configurations settings.” (Right? This section is about protections not detections.)

@opauloh
Copy link
Contributor

opauloh commented Sep 20, 2022

Thanks for the suggestions @benironside!

Edit: updated the PR with the suggestions

Copy link
Contributor

@paul-tavares paul-tavares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all of the changes. It's looking good.

My only concern is the disabling of the ESLint for the react useEffect() hooks. Can we remove those? I can help if needed - let me know.

Copy link
Contributor

@paul-tavares paul-tavares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for all the changes.

@opauloh opauloh enabled auto-merge (squash) September 20, 2022 18:10
@kevinlog
Copy link
Contributor

@opauloh @animehart - just a heads up, this PR skips the flakey test, so make sure you've this in and your PR should pass. One of our PRs was having the same issue.

@opauloh
Copy link
Contributor

opauloh commented Sep 20, 2022

@opauloh @animehart - just a heads up, this PR skips the flakey test, so make sure you've this in and your PR should pass. One of our PRs was having the same issue.

thanks a lot @kevinlog

@opauloh opauloh merged commit 3be835a into elastic:main Sep 20, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 3143 3145 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 6.5MB 6.5MB +6.8KB
Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 409 408 -1

Total ESLint disabled count

id before after diff
securitySolution 481 480 -1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @opauloh

@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:feature Makes this part of the condensed release notes Team: AWP: Visualization AWP team that does most fullstack work in kibana Team:Defend Workflows “EDR Workflows” sub-team of Security Solution ui-copy Review of UI copy with docs team is recommended v8.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants