[TIP] Add to timeline #138836

PhilippeOberti · 2022-08-15T16:28:04Z

Summary

This PR adds buttons to multiple places in the indicators page, to add a field/value pair to an untitled timeline. This mimics the functionality of the Alerts page. Here are the 3 places the Add to Timeline icon button is added to:

to every cells in the indicators table
- the button is only visible if the value in the cell exists (i.e. NOT the empty value -)
- the button isn't shown on the first Actions column of the table, as this one will have the Investigate in Timeline button handled in a future PR (see this ticket)
to a new actions column for the indicator flyout table
to the barchart legend (this implementation slightly differs from the Alerts page, see discussion here)

This PR also cleans up a bit our Storybook stories by extracting some logic out (KibanaContext and SecuritySoluetionContext).

To Do

add new and update storybook stories
write unit and e2e tests
fix type check
add code documentation
verify it's ok to export the interface from the timeline plugin

https://github.com/elastic/security-team/issues/4557

Screen.Recording.2022-08-15.at.6.16.12.PM.mov

How/what to test

When clicking on one of the 3 add to timeline buttons, an entry will be added to the untitled timeline (accessible by clicking on the Untitled timeline button at the bottom left of the screen. The timeline should have a new entry, with the indicator field and its value.

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)

lgestc

Looks good to me overall, the only issue is that column mapping thing I pointed out. Good job:)

x-pack/plugins/security_solution/public/threat_intelligence/routes.tsx

x-pack/plugins/threat_intelligence/kibana.json

...reat_intelligence/public/modules/indicators/components/indicators_table/indicators_table.tsx

YulNaumenko · 2022-08-17T16:30:30Z

I have an overall question: are there any specific reasons why threat intelligence plugin made the decision to implement own data grid instead of reuse T-Grid which is used by security_solution and observability?

This data grid already contains all the row and bulk actions, which is configurable. For example in SessionsViewComponent:

kibana/x-pack/plugins/security_solution/public/common/components/sessions_viewer/index.tsx

Lines 86 to 99 in 69ef96f

    
             <StatefulEventsViewer 
        
               pageFilters={sessionsFilter} 
        
               defaultModel={getSessionsDefaultModel(columns, defaultColumns)} 
        
               end={endDate} 
        
               entityType={entityType} 
        
               id={timelineId} 
        
               leadingControlColumns={leadingControlColumns} 
        
               renderCellValue={DefaultCellRenderer} 
        
               rowRenderers={defaultRowRenderers} 
        
               scopeId={SourcererScopeName.default} 
        
               start={startDate} 
        
               unit={unit} 
        
             /> 
        
           </div>

lgestc · 2022-08-18T08:08:19Z

Hey Yuliia! Well. we did start working on threat intel around july, and I was not aware of TGrid up until the beginning of august, when I stumbled upon it working on adding fields browser to our thing. Shortly after, there was a presentation about it that you made - this is why our current implementation skips the existing API.

One of our primary goals was to kick off the development early, with all of us discovering kibana codebase along the way.
We will surely reuse more code in the future, being more familiar with what is available every day:).

It's just my view, thoughts @maxcold @PhilippeOberti ?

x-pack/plugins/threat_intelligence/cypress/integration/timeline.spec.ts

PhilippeOberti · 2022-08-18T08:32:01Z

I have an overall question: are there any specific reasons why threat intelligence plugin made the decision to implement own data grid instead of reuse T-Grid which is used by security_solution and observability?

hi @YulNaumenko, thanks for the comment!

Our team is pretty new and I'm the freshest of all of us, so my knowledge of the Kibana repo is still very limited 😄
When I started looking at this add to timeline feature I did a naive search throughout the repo for addtotimline and started working on the first thing I found that seemed that it would be working for me.
Like @lgmys said I'm sure we'll be cleaning up things and use the proper ways at a later phase. Actually, do we have documentation on how to use this T-Grid feature? During my investigation I had seen this StatefulEventsViewer using InspectButtonContainer but to be frank I couldn't really understand all the magic that was happening in there 😆

@maxcold do you want me to create a tech debt ticket now or we'll discuss about it in our Tech Planning meeting in a few hours?

maxcold · 2022-08-18T09:43:19Z

@PhilippeOberti @lgmys let's discuss it in our tech planning, we might want to do an investigation first if TGrid has the right level of abstraction for us as not everything we plan to do with our data grid will work exactly the same as in Alerts, for example, "Investigate in Timeline" we invision differently that it currently works in Alerts

@YulNaumenko thanks a lot for investing your time in reviewing the PR, it's great to have someone with a lot of experience with Kibana dev looking at our code as we are all new to Elastic!
I will add my 5 cents to the TGrid discussion, though everything Philippe and Lukasz wrote is correct.
When we started the UX/UI of our data grid looked quite different from what Alerts have currently, only during the work on 8.4 did we decide to be closer to the experience users have in Alerts. As the team already mentioned we try to reuse the functionality available in security_solution and other plugins related to the Security Solution but for someone who hasn't worked on the security_solution codebase before it's not an easy task to discover and understand bits and pieces that can be reused there.
The particular questions I have when looking at TGrid for the first time (I haven't watched your presentation yet, so maybe some of the questions/concerns I have are answered there):

I didn't expect the reusable data grid component living in the Timeline plugin and being called TGrid. Integration with Timeline doesn't seem like smth that defines a data grid as it has a lot of other features like Fields browser, Filter In/Out and integration with KQL in general, sorting, and integration with cases to name a few. The component also has a lot of Alert named components inside, which makes me wonder, if it's coupled to Alerts or if it can be used for any Elastic document, eg. Indicator of Compromise in our case. I totally understand that there is probably a long history behind this component.
Related to the first question, is it the right level abstraction for a new experience in Security Solution? Will it enable us to move faster or will it be a blocker if we need to do things a bit differently in the future? Eg. for "Investigate in timeline" we want to bring not the _id: <id of a document> to the Timeline but a more sophisticated query and it is hard to say by looking at the code if it is supported or not
On a more conceptual level from my experience large and complex components with a lot of options and settings proved to be less effective than small building blocks. It will always be a question of course how to share smth complex built with these lego blocks and when to reuse this complex thing vs rebuilding from the blocks again and again. There are trade-offs to each approach, we are still figuring out the trade-offs applicable to our team and product
And all these questions are very hard to answer for a new team when there is no documentation on a tool or a component. I understand that security_solution plugin moves fast and changes very often, but as it matures I hope we all invest more in the good documentation together

I hope my long comment and newbie feedback on the current component state won't stop you from giving us advice in the future on what is available in security_solution and what can we reuse. As I said in the beginning it is super helpful for us!
We will discuss the usage of TGrid within the team and probably spend a bit more time trying to integrate it into our codebase.

YulNaumenko · 2022-08-19T18:29:34Z

I didn't expect the reusable data grid component living in the Timeline plugin and being called TGrid. Integration with Timeline doesn't seem like smth that defines a data grid as it has a lot of other features like Fields browser, Filter In/Out and integration with KQL in general, sorting, and integration with cases to name a few. The component also has a lot of Alert named components inside, which makes me wonder, if it's coupled to Alerts or if it can be used for any Elastic document, eg. Indicator of Compromise in our case. I totally understand that there is probably a long history behind this component.

@maxcold yes, I agree that TGrid is overloaded with the features. Basically TGrid has two interfaces - the simpler one is for Observability and more feature loaded for Security.
Observability UI:

Security UI:

Another thing about the roadmap for TGrid - together with ResponseOps team we are planning migrate it to the new table currently exposed by triggers_actions_ui plugin. I recommend you take a look (cc @XavierM):

kibana/x-pack/plugins/triggers_actions_ui/public/plugin.ts

Lines 108 to 109 in 2b15e2a

    
           getAlertsTable: (props: AlertsTableProps) => ReactElement<AlertsTableProps>; 
        
           getAlertsStateTable: (props: AlertsTableStateProps) => ReactElement<AlertsTableStateProps>;

Now you can find the example in Cases UI:

Related to the first question, is it the right level abstraction for a new experience in Security Solution?

To be honest - No. And that's why we are working now on the architecture redesign of this component.

Will it enable us to move faster or will it be a blocker if we need to do things a bit differently in the future?

For now it probably could slow you down, but for confirming this assumption I need to know you upcoming requirements and feature on top of the data grid

Eg. for "Investigate in timeline" we want to bring not the _id: <id of a document> to the Timeline but a more sophisticated query and it is hard to say by looking at the code if it is supported or not

We can discuss the details of this requirement.

On a more conceptual level from my experience large and complex components with a lot of options and settings proved to be less effective than small building blocks. It will always be a question of course how to share smth complex built with these lego blocks and when to reuse this complex thing vs rebuilding from the blocks again and again. There are trade-offs to each approach, we are still figuring out the trade-offs applicable to our team and product

Agree, but recommend you to review the new table designed by ResponseOps, which I've mentioned above. Again, we have an upcoming changes to simplify and separate TGrid by reusable parts.

And all these questions are very hard to answer for a new team when there is no documentation on a tool or a component. I understand that security_solution plugin moves fast and changes very often, but as it matures I hope we all invest more in the good documentation together

Unfortunately this is a known problem. Security teams are working now to make a documentation better and add the visibility over the code base. Please, help us to move this initiative.

I hope my long comment and newbie feedback on the current component state won't stop you from giving us advice in the future on what is available in security_solution and what can we reuse. As I said in the beginning it is super helpful for us! We will discuss the usage of TGrid within the team and probably spend a bit more time trying to integrate it into our codebase.

Please, invite me to the discussion if it makes sense for the team. I'm happy to help. Feel free to reach out with any technical questions you have.

maxcold · 2022-08-22T12:41:21Z

@YulNaumenko thanks a lot for more context on the TGrid! I created an issue in our backlog to play with TGrid for our Indicators view #138836 (comment), feel free to add any context you think is missing there

For now it probably could slow you down, but for confirming this assumption I need to know you upcoming requirements and feature on top of the data grid

this is a hard part as we don't yet have a long-term vision for our feature, we want to put it out there and get feedback from our users before planning too far ahead. Filtering in/out, sorting and integration with Cases are on our roadmap for sure

We can discuss the details of this requirement.

You can find more details in this issue https://github.com/elastic/security-team/issues/4558

Please, invite me to the discussion if it makes sense for the team. I'm happy to help. Feel free to reach out with any technical questions you have.

We had this discussion last week, where we agreed that we need to investigate TGrid capabilities closer but also decided that it's not a top priority for us right now. We will keep in mind that you are happy to help us with the context on TGrid when we get to building some POC with it

maxcold · 2022-08-22T12:44:07Z

x-pack/plugins/threat_intelligence/README.md

 ```
 yarn kbn reset && yarn kbn bootstrap
 yarn start --no-base-path
 ```

+> **Notes:**
+> 
+> It is recommended to set `server.basePath: "/kbn"` to make you local instance persist the base Kibana path, otherwise the base path will be a random string every time you start Kibana. Any other value than `/kbn` will also work.


while this plugin is the only artifact that we own, should we just link to https://docs.elastic.dev/security-solution/protections/protections-experience-team/dev-setup to have one source of truth? (or wise-versa ofc if you think README is a better place )

yup I'm ok with that, I'm modifying this README to point to the dev-setup one!

maxcold · 2022-08-22T12:51:19Z

...s/threat_intelligence/public/modules/timeline/components/add_to_timeline/add_to_timeline.tsx

+    return result;
+  }, [component, dataProvider, field]);
+
+  return value === EMPTY_VALUE ? (


does it make sense to return early from the component?
smth like

if (!value) { return <></> }

right after getting the value

unless I'm mistaken you shouldn't use useMemo (or any other react hooks) conditionally. By that I mean I believe it's not good to have a early return on a component and have a react hook after that. If that is true I don't think you can return this <></> empty component any earlier than it is currently...

Am I mistaken?

yes you are right, couple of thoughts:

one of the reasons I wasn't really sold on the idea of using memorization extensively without clearly measured performance gains was that it comes with a cost, in this case we need to adjust the way we code to the fact that we use hooks. not really specific to useMemo but to all hooks ofc

When looking at the component I'm a bit confused with the fact that we wrap the whole component in memo HOC and also use useMemo inside. If the component is wrapped in memo are there gains of using useMemo inside it additionally?

initially the usage of EMPTY_VALUE caught my eye. Do we really need this logic of assigning EMPTY_VALUE and then checking against it? We used EMPTY_VALUE as an UI component for an empty cell, I wouldn't introduce it if it doesn't serve the purpose of displaying - somewhere

I took the opportunity to read more about useMemo vs React.memo when to use them when to now.
I feel like this addToTimeline component for sure doesn't need to be wrapped by a memo.
Also, I feel like that the use of useMemo inside it is also not providing any positive value (I was doing useMemo on the creation of a basic object, not any complex heavy logic..)

I have removed both of them (to be honest the code was lifted off of a Security Solution component). This allows me like you mentioned to early return if value is undefined.

I will be more careful in the future about when to use vs not to use this. I also ned to learn about performance testing with React!
Thanks for challenging me on this!

maxcold · 2022-08-22T13:57:25Z

@PhilippeOberti two comments after running the branch locally:

there is a small visual improvement we can make - align "expand" and "add to timeline" icons in the data grid

I see that "add to timeline" is not available on the Indicator column. My thinking was that we also want to support it for that column, it will just require some custom logic compare to all other columns

maxcold · 2022-08-22T17:12:09Z

one comment on my comment :)
regarding

I see that "add to timeline" is not available on the Indicator column. My thinking was that we also want to support it for that column, it will just require some custom logic compare to all other columns

I'm also totally ok with having this covered in a separate PR

YulNaumenko

On the current stage of the discussion the timelines changes LGTM

PhilippeOberti · 2022-08-23T07:27:13Z

@PhilippeOberti two comments after running the branch locally:

there is a small visual improvement we can make - align "expand" and "add to timeline" icons in the data grid

I see that "add to timeline" is not available on the Indicator column. My thinking was that we also want to support it for that column, it will just require some custom logic compare to all other columns

Good catch on the alignment of the icon. This is now fixed thank you!
For the add to timeline in the Indicator column, I just needed to add some custom logic, wasn't too difficult. It's here if you want to check it out

- add button to all cells in the indicators table - add button to a new actions column for the indicator flyout table - add button to barchart legend - create new providers (kibana context and security context) for unit tests and storybook - change all Storybook console.log to window.alert to follow the EUI pattern - fix broken Storybook indicator table story elastic/security-team#4557

maxcold · 2022-08-23T10:02:33Z

...s/threat_intelligence/public/modules/timeline/components/add_to_timeline/add_to_timeline.tsx

+  if (typeof data === 'string') {
+    value = data;
+  } else if (field === ComputedIndicatorFieldId.DisplayValue) {
+    field = indicatorTypeToFieldMap[unwrapValue(data, RawIndicatorFieldId.Type) || ''];


should we add some helper function in indicators/lib to get the display_name original field by an IoC type? We will probably need it for other features, eg. for filter in/out

I had thought about it but decided against it as it's only a one liner... I will extract it!

agree, don't have a strong opinion, maybe it's a preemptive optimisation as well :)

extracted like we discussed, colocated with the displayValue method

maxcold · 2022-08-23T10:03:01Z

...eat_intelligence/public/modules/timeline/components/add_to_timeline/add_to_timeline.test.tsx

+import { AddToTimeline } from './add_to_timeline';
+import { TestProvidersComponent } from '../../../../common/mocks/test_providers';
+
+describe('<AddToTimeline />', () => {


I think we need to add more test cases to cover the logic for display value

good idea! When I first wrote this component it was a lot simpler, but now that it has more logic I need to add more test cases!

added! Now supporting:

good value/field input (both string and Indicator type)

value is EMPTY_VALUE has input

calculated value is null

field doesn't exist in the Indicator

field exist but has an unknown value (meaning NOT url, file or ip for now)

maxcold · 2022-08-23T10:05:56Z

x-pack/plugins/threat_intelligence/common/types/indicator.ts

+export const indicatorTypeToFieldMap: { [id: string]: RawIndicatorFieldId } = {
+  file: RawIndicatorFieldId.FileSha256,
+  url: RawIndicatorFieldId.UrlFull,
+  ip: RawIndicatorFieldId.Ip,


I believe this won't work for ip indicator. The type possible values for the IP indicator are ipv4-addr and ipv6-addr. In general, I'd think of how we could avoid having this mapping separate from the logic we have in display_value.ts file. Every time we add support for a new type of indicator we would need to remember to add the mapping here, which is very error prone

I know but couldn't find a better way to do this. I stole the logic from here where we return the actual value to display. We have a ruleArray with only 3 options: isIpIndicator, isUrlIndicator and isFileIndicator with the extract method hardcoded. To your knowledge do we have a better solution to do this?

my main point that the logic in add_to_timeline.tsx

field = indicatorTypeToFieldMap[unwrapValue(data, RawIndicatorFieldId.Type) || ''];

won't even work, because unwrapValue(data, RawIndicatorFieldId.Type) will return ipv4-addr and you don't have a mapping for that. Ofc the simplest would be to add all the possible keys from https://docs.google.com/spreadsheets/d/1oYx9CQodKVmr0OtlJcjm1mNoUBlDcbHai0UYxtP8YzY/edit#gid=1814426429

file url email-addr email (doesn't exist in STIX 2.0) email-message domain-name domain ipv4-addr ipv6-addr x509-certificate x509 Serial (doesn't exist in STIX 2.0) windows-registry-key autonomous-system suppress (doesn't exist in STIX 2.0) mac-addr unknown

to the mapping, but then when a new type is added I'm 99% confident that we won't add it to the mapping until a user complain :)
Let me think on how we could awoid that

ok thanks for the pointer, I will spend time thinking about a good way to handle this!

for now still with a very basic key-value object, like discussed a cleaner work will be done in this ticket

maxcold · 2022-08-23T10:11:01Z

...s/threat_intelligence/public/modules/timeline/components/add_to_timeline/add_to_timeline.tsx

+  if (typeof data === 'string') {
+    value = data;
+  } else if (field === ComputedIndicatorFieldId.DisplayValue) {
+    field = indicatorTypeToFieldMap[unwrapValue(data, RawIndicatorFieldId.Type) || ''];


unwrapValue can be null, I think that's because you have || '' there but I'd prefer more direct handling of null case. Right now it's a bit unclear what will be rendered if unwrapValue returns null, to me it seems that the component will go in some undefined state

good point!

this is now handled, along side an EMPTY_VALUE I had forgotten to support and that my newly added unit tests revealed :)

maxcold · 2022-08-23T10:12:25Z

x-pack/plugins/threat_intelligence/public/modules/timeline/components/add_to_timeline/styles.ts

@@ -5,11 +5,14 @@
 * 2.0.
 */

-export function mockUiSetting(key: string): string | undefined {


very weird diff, is it just git incorrectly interpreting it as a rename of the file?

yeah for some reason git thinks I've renamed the file. Let me try to delete and recreate it real quick...

didn't fix this as I would have had to amend the commit instead of adding a new one...

- still using basic key value pair for now - add more unit tests

maxcold · 2022-08-23T15:30:44Z

x-pack/plugins/threat_intelligence/public/modules/indicators/lib/display_value.ts

+ */
+const indicatorTypeToField: { [id: string]: RawIndicatorFieldId } = {
+  file: RawIndicatorFieldId.FileSha256,
+  'ipv4-addr': RawIndicatorFieldId.UrlFull,


I believe ipv4-addr and ipv6-addr should have replaced ip mapping, not the url one

kibana-ci · 2022-08-24T10:40:59Z

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`threatIntelligence`	126	129	+3

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`threatIntelligence`	4	3	-1
`timelines`	340	343	+3
total			+2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`threatIntelligence`	62.5KB	63.7KB	+1.2KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
`timelines`	32	33	+1

Unknown metric groups

API count

id	before	after	diff
`timelines`	445	449	+4

ESLint disabled line counts

id	before	after	diff
`threatIntelligence`	12	7	-5

Total ESLint disabled count

id	before	after	diff
`threatIntelligence`	13	8	-5

History

💔 Build #66964 failed 3e25136
💚 Build #66739 succeeded a651fa1
💚 Build #66681 succeeded c1cbf89
💔 Build #66669 failed c3006c0a7abb97a72b5a28466134c7bb1c297c9b
💔 Build #66652 failed accaccea624b4e1dd7432d08a1cae914e2fbd87c

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* [TIP] Add to timeline - add button to all cells in the indicators table - add button to a new actions column for the indicator flyout table - add button to barchart legend - create new providers (kibana context and security context) for unit tests and storybook - change all Storybook console.log to window.alert to follow the EUI pattern - fix broken Storybook indicator table story elastic/security-team#4557

elasticmachine · 2022-09-28T11:33:59Z

Pinging @elastic/security-solution (Team: SecuritySolution)

PhilippeOberti requested review from maxcold and lgestc August 17, 2022 07:31

PhilippeOberti force-pushed the add-to-timeline branch from 8601213 to 4fc2b5d Compare August 17, 2022 07:43

lgestc added the Team: Protections Experience label Aug 17, 2022

lgestc requested changes Aug 17, 2022

View reviewed changes

lgestc self-requested a review August 17, 2022 09:12

PhilippeOberti marked this pull request as ready for review August 17, 2022 12:58

PhilippeOberti requested review from a team as code owners August 17, 2022 12:58

PhilippeOberti added release_note:skip Skip the PR/issue when compiling release notes 8.5 candidate v8.5.0 labels Aug 17, 2022

lgestc approved these changes Aug 18, 2022

View reviewed changes

PhilippeOberti commented Aug 18, 2022

View reviewed changes

x-pack/plugins/threat_intelligence/cypress/integration/timeline.spec.ts Outdated Show resolved Hide resolved

maxcold reviewed Aug 22, 2022

View reviewed changes

YulNaumenko approved these changes Aug 22, 2022

View reviewed changes

PhilippeOberti force-pushed the add-to-timeline branch from 0062ae9 to 5a36c05 Compare August 23, 2022 07:23

PhilippeOberti requested a review from a team as a code owner August 23, 2022 07:23

PhilippeOberti force-pushed the add-to-timeline branch 2 times, most recently from 9306a89 to c3006c0 Compare August 23, 2022 08:48

PhilippeOberti removed the request for review from a team August 23, 2022 08:49

PhilippeOberti force-pushed the add-to-timeline branch from c3006c0 to c1cbf89 Compare August 23, 2022 09:39

maxcold requested changes Aug 23, 2022

View reviewed changes

[TIP] Colocate displayField with displayValue

a651fa1

- still using basic key value pair for now - add more unit tests

maxcold reviewed Aug 23, 2022

View reviewed changes

PhilippeOberti added 2 commits August 24, 2022 10:22

[TIP] Fix wrong field for url/ip mapping

973b42c

Merge branch 'main' into add-to-timeline

3e25136

maxcold approved these changes Aug 24, 2022

View reviewed changes

[TIP] Fix unit test

98a56c3

PhilippeOberti merged commit e3181e6 into elastic:main Aug 24, 2022

kibanamachine added the backport:skip This commit does not require backporting label Aug 24, 2022

PhilippeOberti deleted the add-to-timeline branch August 24, 2022 10:42

PhilippeOberti mentioned this pull request Sep 12, 2022

[TIP] Investigate in timeline #140496

Merged

4 tasks

maxcold mentioned this pull request Sep 27, 2022

[DOCS] Threat Intelligence - Indicators Page and Indicator Details elastic/security-docs#2497

Closed

2 tasks

maxcold added release_note:feature Makes this part of the condensed release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. and removed release_note:skip Skip the PR/issue when compiling release notes labels Sep 28, 2022

[TIP] Add to timeline #138836

[TIP] Add to timeline #138836

Conversation

PhilippeOberti commented Aug 15, 2022 • edited Loading

Summary

To Do

How/what to test

Checklist

lgestc left a comment

Choose a reason for hiding this comment

YulNaumenko commented Aug 17, 2022

lgestc commented Aug 18, 2022 • edited Loading

PhilippeOberti commented Aug 18, 2022

maxcold commented Aug 18, 2022 • edited Loading

YulNaumenko commented Aug 19, 2022

maxcold commented Aug 22, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

maxcold commented Aug 22, 2022

maxcold commented Aug 22, 2022

YulNaumenko left a comment

Choose a reason for hiding this comment

PhilippeOberti commented Aug 23, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

maxcold Aug 23, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kibana-ci commented Aug 24, 2022

💚 Build Succeeded

Metrics [docs]

Module Count

Public APIs missing comments

Async chunks

Public APIs missing exports

API count

ESLint disabled line counts

Total ESLint disabled count

History

elasticmachine commented Sep 28, 2022

PhilippeOberti commented Aug 15, 2022 •

edited

Loading

lgestc commented Aug 18, 2022 •

edited

Loading

maxcold commented Aug 18, 2022 •

edited

Loading

maxcold Aug 23, 2022 •

edited

Loading