Bump redux (4.2.0), reselect (4.1.6), @reduxjs/toolkit (1.7.2), redux-thunk (2.4.1) and immer (9.0.15) #138818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sphilipse
added
release_note:skip
sphilipse
force-pushed
the
upgrade-redux-4-1-0
branch
from
51411ab to
f6c4957
Compare
byronhulcher
approved these changes
Aug 15, 2022
sphilipse
force-pushed
the
upgrade-redux-4-1-0
branch
3 times, most recently
from
9829b41 to
a7db1ed
Compare
sphilipse
changed the title
sphilipse
changed the title
sphilipse
commented
Aug 22, 2022
| @@ -554,28 +554,9 @@ export const nodesAndEdgelines: (state: DataState) => ( | |||
| processNodePositions: visibleProcessNodePositions, | |||
| connectingEdgeLineSegments, | |||
| }; | |||
| }, aaBBEqualityCheck); | |||
| }, aabbModel.isEqual); | |||
There was a problem hiding this comment.
New reselect package correctly induces the type here, so the helper function below is no longer necessary. Functionality is the same.
sphilipse
commented
Aug 22, 2022
| // `boundingBox` and `nodesAndEdgelines` are each memoized. | ||
| return (time: number) => nodesAndEdgelines(boundingBox(time)); | ||
| return (time: number) => nodesAndEdgelinesFn(boundingBoxFn(time)); |
There was a problem hiding this comment.
TypeScript did not like the variable name shadowing here, fixing that fixed a type issue below.
sphilipse
commented
Aug 22, 2022
| visibleNodesAndEdgeLines, | ||
| composeSelectors(dataStateSelector, dataSelectors.ariaFlowtoCandidate), | ||
| (visibleNodesAndEdgeLinesAtTime, ariaFlowtoCandidate) => { | ||
| function ( |
There was a problem hiding this comment.
Couldn't get this to work with an arrow function, TypeScript stopped complaining as soon as I turned this into an explicit function declaration instead.
sphilipse
changed the title
|
Pinging @elastic/enterprise-search-frontend @elastic/kibana-presentation @elastic/kibana-data-discovery @elastic/platform-deployment-management @elastic/infra-monitoring-ui @elastic/kibana-gis @elastic/security-solution for reviews and sanity checks as your code may be affected by this upgrade. |
jbudz
reviewed
Aug 22, 2022
botelastic
bot
added
the
Team:Uptime - DEPRECATED
|
Pinging @elastic/uptime (Team:uptime) |
jbudz
approved these changes
Aug 22, 2022
|
@sphilipse would you mind adding a proper config to |
Co-authored-by: Patryk Kopyciński <[email protected]>
Co-authored-by: Patryk Kopyciński <[email protected]>
Co-authored-by: Patryk Kopyciński <[email protected]>
sphilipse
force-pushed
the
upgrade-redux-4-1-0
branch
from
974dc67 to
df8279b
Compare
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
Unknown metric groupsESLint disabled in files
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
awahab07
approved these changes
Aug 25, 2022
|
Hey @sphilipse. Thanks for bumping those. I've checked our implementation with the latest That's not something we should fix on our side, it's actually a bug on the library side. I've already reported an issue reduxjs/redux-toolkit#2628 and proposed a solution in reduxjs/redux-toolkit#2629. Let's see how it goes with the PR. If it's going to be rejected or before they release that, we can use the following as a workaround: // src/plugins/embeddable/public/store/create_store.ts
export interface CreateStoreOptions<S extends State>
// @todo remove type parameters when reduxjs/redux-toolkit#2628 is resolved
// @see https://github.com/reduxjs/redux-toolkit/issues/2628
extends Omit<ConfigureStoreOptions<S, AnyAction, Middleware[]>, 'reducer'> {
reducer?: Reducer<S> | Optional<ReducersMapObject<S>, keyof State>;
}cc @ThomThomson |
Mpdreamz
pushed a commit
to Mpdreamz/kibana
that referenced
this pull request
Sep 6, 2022
…-thunk (2.4.1) and immer (9.0.15) (elastic#138818) * Upgrade Redux to 4.2.0 and Reselect to 4.1.6 * Fix typing in timelines TypedUseSelectorHook * Upgrade reduxjs-toolkit and fix types * Upgrade more dependencies and fix types * [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix' * Undo unnecessary type fixes * Add renovate.json config for redux * Add caret to @reduxjs/toolkit version * Update package.json Co-authored-by: Patryk Kopyciński <[email protected]> * Update package.json Co-authored-by: Patryk Kopyciński <[email protected]> * Update package.json Co-authored-by: Patryk Kopyciński <[email protected]> * yarn bootstrap * Ts-ignore failing types in presentation_util redux_embeddables * Downgrade @reduxjs/toolkit to 1.7.2 * Undo ts-ignores in redux-embeddables * Remove CombinedState comment * Rebase onto main Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Patryk Kopyciński <[email protected]>
1 task
walterra
added a commit
that referenced
this pull request
Jan 22, 2024
## Summary Follow up to #138818. This updates Redux Toolkit to the latest version right before v2. It also updates dependencies of Redux Toolkit that are also in `package.json` to match the version used in Redux Toolkit. - Upgrades `@reduxjs/toolkit` from `v1.7.2` to `v1.9.7`. - Upgrades `immer` from `v9.0.15` to `v9.0.21`. - Upgrades `redux` from `v4.2.0` to `v4.2.1`. - Upgrades `redux-thunk` from `v2.4.1` to `v2.4.2`. - Upgrades `reselect` from `v4.1.6` to `v4.1.8`. ### Checklist - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
CoenWarmer
pushed a commit
to CoenWarmer/kibana
that referenced
this pull request
Feb 15, 2024
## Summary Follow up to elastic#138818. This updates Redux Toolkit to the latest version right before v2. It also updates dependencies of Redux Toolkit that are also in `package.json` to match the version used in Redux Toolkit. - Upgrades `@reduxjs/toolkit` from `v1.7.2` to `v1.9.7`. - Upgrades `immer` from `v9.0.15` to `v9.0.21`. - Upgrades `redux` from `v4.2.0` to `v4.2.1`. - Upgrades `redux-thunk` from `v2.4.1` to `v2.4.2`. - Upgrades `reselect` from `v4.1.6` to `v4.1.8`. ### Checklist - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This updates redux to 4.2.0, reselect to 4.1.6, @reduxjs/toolkit to 1.7.2, redux-thunk to 2.4.1 and immer to 9.0.15. The main aim was to upgrade redux, the other package updates fix type errors caused by upgrading redux in isolation.