Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lens embeddables/all #138791

Closed
wants to merge 112 commits into from
Closed

Lens embeddables/all #138791

wants to merge 112 commits into from

Conversation

angorayc
Copy link
Contributor

@angorayc angorayc commented Aug 15, 2022

Summary

issue: #136409

We'd like to move KPI charts to Lens Embeddables, so they will be compatible with custom dashboards.
This means some the layout of KPIs are changed.
The order of chart actions are arranged alphabetically.
The inspect modal is changed and more actions are available from the modal.

Kibana: https://kibana-pr-137882.kb.us-west2.gcp.elastic-cloud.com:9243/
ask me or Monina for password

This PR is for cloud deployment, demo, and UI review - This is the combination of the 3 PRs below:

Hosts

Screenshot 2022-08-17 at 20 40 57

Host details

Screenshot 2022-08-08 at 11 21 31

Users
Screenshot 2022-08-08 at 11 22 15

Network
Screenshot 2022-08-08 at 11 21 59

Inspector

Screen.Recording.2022-08-17.at.20.24.27.mov

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

angorayc and others added 30 commits August 9, 2022 10:13
replace users kpi with lens embeddables
angorayc and others added 25 commits August 17, 2022 13:55
@kibana-ci
Copy link
Collaborator

kibana-ci commented Aug 17, 2022

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Security Solution Tests #3 / Hover actions Adds global filter - filter in
  • [job] [logs] Security Solution Tests #3 / Hover actions Adds global filter - filter in
  • [job] [logs] Security Solution Tests #3 / Hover actions Adds global filter - filter out
  • [job] [logs] Security Solution Tests #3 / Hover actions Adds global filter - filter out

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 3040 3037 -3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.2MB 1.2MB +30.0B
securitySolution 5.4MB 5.3MB -16.8KB
total -16.7KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
lens 34.5KB 34.6KB +58.0B
securitySolution 255.0KB 255.1KB +86.0B
total +144.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@gvnmagni
Copy link

wing with the security design team, we have concerns about the layout of the metrics when using the new Lens embeddable component. It's hard to understand what icons and words are grouped with each metric, especially in the user authenticat

Always happy to help! Please feel free to reach out on slack using the #charts channel 😊

@monina-n
Copy link

@angorayc here's the pr for the new lens metric visualization updates I mentioned: #136567

@angorayc
Copy link
Contributor Author

angorayc commented Oct 4, 2022

continue in #142606

@angorayc angorayc closed this Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:cloud-deploy Create or update a Cloud deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants