Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix console tests on cloud #138682

Merged
merged 7 commits into from
Aug 12, 2022
Merged

Conversation

liza-mae
Copy link
Contributor

@liza-mae liza-mae commented Aug 11, 2022

Fixes cloud test failure in: #137744

  1. Adds security role access to the indices accessed by the test
  2. Cleans up role access after test is done
  3. Adds option to close welcome fly out if it shows

Also fixes cloud test failure in: #133428

Adds security role access to sample data

@liza-mae liza-mae self-assigned this Aug 11, 2022
@liza-mae liza-mae added release_note:skip Skip the PR/issue when compiling release notes v8.5.0 v8.4.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Aug 11, 2022
@liza-mae liza-mae requested review from dimaanj and a team August 11, 2022 21:52
@cjcenizal cjcenizal added Feature:Console Dev Tools Console Feature Feature:Dev Tools Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more labels Aug 11, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/platform-deployment-management (Team:Deployment Management)

Copy link
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! Code LGTM.

@liza-mae liza-mae changed the title Fix console test on cloud Fix console tests on cloud Aug 11, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @liza-mae

@liza-mae liza-mae merged commit a9a1828 into elastic:main Aug 12, 2022
@liza-mae liza-mae deleted the liza/fix-console-cloud-test branch August 12, 2022 16:03
kibanamachine pushed a commit that referenced this pull request Aug 12, 2022
* Fix console test on cloud

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

* Fix access to sample data

* Clean up access after test

* Fix restore test

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit a9a1828)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.4

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Aug 16, 2022
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Aug 17, 2022
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Aug 17, 2022
* Fix console test on cloud

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

* Fix access to sample data

* Clean up access after test

* Fix restore test

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit a9a1828)

Co-authored-by: liza-mae <[email protected]>
Mpdreamz pushed a commit to Mpdreamz/kibana that referenced this pull request Sep 6, 2022
* Fix console test on cloud

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

* Fix access to sample data

* Clean up access after test

* Fix restore test

Co-authored-by: kibanamachine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Console Dev Tools Console Feature Feature:Dev Tools release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v8.4.0 v8.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants