Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.4] [ML] APM Correlations: Fix chart errors caused by inconsistent histogram range steps. (#138259) #138637

Merged
merged 2 commits into from
Aug 11, 2022

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.4:

Questions ?

Please refer to the Backport tool documentation

…ram range steps. (elastic#138259)

The `AreaSeries` for the latency correlations charts expect the provided timestamp keys for each series to be the same, otherwise there might be errors in how the chart renders the areas. In some cases this could happen because we fetch the data for the areas independently (for example overall latency and failed transactions latency).

The fix provided by this PR adds optional `durationMin` and `durationMax` parameters to affected endpoints. This way the `durationMin/Max` returned by the first area request (for example "overall latency") can be passed on to the second request to enforce the same buckets/keys (for example for "failed transaction latency").

(cherry picked from commit 3aabd88)
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@walterra
Copy link
Contributor

@elasticmachine merge upstream

@kibanamachine kibanamachine merged commit fb25009 into elastic:8.4 Aug 11, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 3.0MB 3.0MB +493.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @walterra

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:APM All issues that need APM UI Team support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants