Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade EUI to v63.0.6 - updates to new EuiPageTemplate and deprecates old page components #138546

Closed
wants to merge 42 commits into from

Commits on Aug 31, 2022

  1. Configuration menu
    Copy the full SHA
    0fd7619 View commit details
    Browse the repository at this point in the history
  2. EuiPageContent_Deprecated as EuiPageContent

    cchaos authored and cee-chen committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    05e425e View commit details
    Browse the repository at this point in the history
  3. EuiPageContentBody_Deprecated as EuiPageContentBody

    cchaos authored and cee-chen committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    dbd8cb5 View commit details
    Browse the repository at this point in the history
  4. EuiPageContentHeader_Deprecated as EuiPageContentHeader

    cchaos authored and cee-chen committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    7bb33f3 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    e630ef7 View commit details
    Browse the repository at this point in the history
  6. EuiPageSideBar_Deprecated as EuiPageSideBar

    cchaos authored and cee-chen committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    fd86313 View commit details
    Browse the repository at this point in the history
  7. EuiPageContent__Deprecated to EuiPageContent_Deprecated

    cchaos authored and cee-chen committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    f7799d0 View commit details
    Browse the repository at this point in the history
  8. Fix rogue semi-colons

    cchaos authored and cee-chen committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    b703883 View commit details
    Browse the repository at this point in the history
  9. WIP: NoDataConfigPage & NoDataPage converted to new template

    - `withSolutionNav` not yet handled
    cchaos authored and cee-chen committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    ebde599 View commit details
    Browse the repository at this point in the history
  10. WIP: KibanaPageTemplateInner converted to use new template

    - Pushes existing `pageHeader` prompts onto created EuiPageTemplate.PageHeader
    - Uses `isEmptyState` to push `pageHeader` props to EuiPageTemplate.EmptyPrompt instead (if `children` are not supplied)
    cchaos authored and cee-chen committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    5ed12e5 View commit details
    Browse the repository at this point in the history
  11. WIP: withSolutionNav now renders the sidebar content properly

    - Collapsing isn’t working (minWidth isn’t updating)
    cchaos authored and cee-chen committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    daa4f22 View commit details
    Browse the repository at this point in the history
  12. Fixing stickiness of sidebar

    cchaos authored and cee-chen committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    084ba5d View commit details
    Browse the repository at this point in the history
  13. [Security] Fixed SecuritySolutionTemplateWrapper’s usage

    - Moved `bottomBar` to EuiPageTemplate.BottomBar (now contained in just the page contents)
    - Change EuiPanel children wrapper with EuiPageTemplate.Section
    cchaos authored and cee-chen committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    d31c407 View commit details
    Browse the repository at this point in the history
  14. [O11y] Wrap children with EuiPageTemplate.Section

    cchaos authored and cee-chen committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    2479ee5 View commit details
    Browse the repository at this point in the history
  15. Fix getting_started usage

    cchaos authored and cee-chen committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    2194df8 View commit details
    Browse the repository at this point in the history
  16. WIP: Fixing types

    cchaos authored and cee-chen committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    9885089 View commit details
    Browse the repository at this point in the history
  17. Removing template pass through

    cchaos authored and cee-chen committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    50aa9db View commit details
    Browse the repository at this point in the history
  18. Set EUI to 63.0.0

    cchaos authored and cee-chen committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    770991c View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    75e1765 View commit details
    Browse the repository at this point in the history
  20. More import fixes

    cchaos authored and cee-chen committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    141b27e View commit details
    Browse the repository at this point in the history
  21. Sidebar component update

    cchaos authored and cee-chen committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    20c3eb1 View commit details
    Browse the repository at this point in the history
  22. Expand KibanaPageTemplate to all namespaced EUI counterparts

    - Updated `docs/tutorials` mdx page
    - Fixed SolutionNav prop types
    cchaos authored and cee-chen committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    22811d0 View commit details
    Browse the repository at this point in the history
  23. Updated the tutorial mdx page

    cchaos authored and cee-chen committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    a252937 View commit details
    Browse the repository at this point in the history
  24. [Stack Management] Updated app layout to new template

    - Some temporary props applied for BWC until all other pages can be converted
    - Converted `API Keys` page’s layout (and especially prompt usags) to new paradigm
    cchaos authored and cee-chen committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    9812251 View commit details
    Browse the repository at this point in the history
  25. Fix circular dep

    cchaos authored and cee-chen committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    78bf875 View commit details
    Browse the repository at this point in the history
  26. Fix new circular dependency

    - copying and pasting types from KibanaPageTemplateProps, but ah well
    cee-chen committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    2066ae4 View commit details
    Browse the repository at this point in the history
  27. Configuration menu
    Copy the full SHA
    289a5db View commit details
    Browse the repository at this point in the history
  28. [O11y] Allow customizing EuiPageTemplate.Section wrapper

    - converts pageBodyProps
    - fixes non-centered loading template
    cee-chen committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    6314661 View commit details
    Browse the repository at this point in the history
  29. [Enterprise Search] Update page templates

    - fix layouts by auto-wrapping an EuiPageSection for padding, while adding a `customPageSections` prop for more custom sections/layouts
    
    - re-center 404 errors
    
    - update tests
    cee-chen committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    d0a5db4 View commit details
    Browse the repository at this point in the history
  30. Configuration menu
    Copy the full SHA
    dba7d8c View commit details
    Browse the repository at this point in the history
  31. Update snapshots

    cee-chen committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    4b495d3 View commit details
    Browse the repository at this point in the history
  32. Configuration menu
    Copy the full SHA
    a11f0f3 View commit details
    Browse the repository at this point in the history
  33. Configuration menu
    Copy the full SHA
    30dc162 View commit details
    Browse the repository at this point in the history
  34. Update failing dashboard snapshots

    - drop shadow changed slightly in EUI
    cee-chen committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    ef0bef7 View commit details
    Browse the repository at this point in the history
  35. Configuration menu
    Copy the full SHA
    1d49a7c View commit details
    Browse the repository at this point in the history
  36. Configuration menu
    Copy the full SHA
    d90afc4 View commit details
    Browse the repository at this point in the history
  37. [O11y][Uptime] Fix missing bottom bars

    - Modifies ObservabilityPageTemplate to accept a `bottomBar` prop (a la the old EuiPageTemplate behavior)
    
    NOTE: This opinionated page layout structure is starting to feel like it could be potentially limiting / have all the same pitfalls the previous EuiPageTemplate did. If so, consider something closer to the Enterprise Search page template conversion (`customPageSections`).
    
    - Misc cleanup: Use `KibanaPageTemplate` over `EuiPageTemplate`
    cee-chen committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    b253c08 View commit details
    Browse the repository at this point in the history
  38. [O11y] Fix route template typing

    - Since theObservabilityPageTemplate is using the new Eui/KibanaPageTemplate, its child templates and types need to be updated accordingly
    cee-chen committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    bcaa2d5 View commit details
    Browse the repository at this point in the history
  39. Fix broken minWidth behavior

    - was an EUI issue that required a patch release
    + update snapshots
    cee-chen committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    d708d79 View commit details
    Browse the repository at this point in the history
  40. [Security Solution] Type fixes, restore empty state

    - Fix empty state logic removed in a previous commit
    - bogarts KibanaPageTemplate's `isEmptyState` prop instead of using `template="noData"`
    
    - extend template wrappers to past ...rest to underlying Kibana/EuiPageTemplate
    
    + replace EuiPageTemplate with KibanaPageTemplate for consistency
    cee-chen committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    49ed352 View commit details
    Browse the repository at this point in the history
  41. Configuration menu
    Copy the full SHA
    f1c9ff8 View commit details
    Browse the repository at this point in the history
  42. Grab EUI v63.0.6

    - for deprecation tags and section tag support
    cee-chen committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    9f94033 View commit details
    Browse the repository at this point in the history