Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet][Test] Add cypress test for force installing unverified package assets #138447

Merged
merged 3 commits into from
Aug 10, 2022

Conversation

hop-dev
Copy link
Contributor

@hop-dev hop-dev commented Aug 9, 2022

Summary

part of #133822

Cypress test to assert that the force install modal appears when trying to install the assets of an unverified package.

also asserts that the package is force installed if the user elects to continue.

@hop-dev hop-dev added test release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.4.0 backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Aug 9, 2022
@hop-dev hop-dev self-assigned this Aug 9, 2022
@hop-dev hop-dev requested a review from a team as a code owner August 9, 2022 18:43
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

const installAnyway = cy.getBySel('confirmModalConfirmButton').contains('Install anyway');
installAnyway.click();

// cypress 'hack' to get all requests made to an intercepted request
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for documenting this, it's not obvious

Copy link
Member

@kpollich kpollich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome stuff thank you for this!

@hop-dev hop-dev force-pushed the 133822-install-cypress-test branch from 5532d3d to 589700c Compare August 10, 2022 14:10
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 868.0KB 868.0KB +39.0B

History

  • 💔 Build #64056 failed 5532d3dc67a4f6b80d944c815c7d5ead9ff3db3d

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @hop-dev

@hop-dev hop-dev merged commit 204bdb6 into elastic:main Aug 10, 2022
@hop-dev hop-dev deleted the 133822-install-cypress-test branch August 10, 2022 18:56
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 10, 2022
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.4

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team test v8.4.0 v8.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants