Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Make Kubernetes manifest file extension consistent #138306

Merged
merged 4 commits into from Aug 8, 2022
Merged

[Fleet] Make Kubernetes manifest file extension consistent #138306

merged 4 commits into from Aug 8, 2022

Conversation

ghost
Copy link

@ghost ghost commented Aug 8, 2022

This is for the issue #137672
Summarize your PR. If it involves visual changes include a screenshot or gif.

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@ghost ghost self-requested a review as a code owner August 8, 2022 18:25
@kibanamachine
Copy link
Contributor

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Aug 8, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@ghost
Copy link
Author

ghost commented Aug 8, 2022

@elasticmachine merge upstream

@kpollich
Copy link
Member

kpollich commented Aug 8, 2022

buildkite test this

@kpollich
Copy link
Member

kpollich commented Aug 8, 2022

@elasticmachine run elasticsearch-ci/docs

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 867.9KB 867.9KB -1.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kpollich kpollich added auto-backport Deprecated - use backport:version if exact versions are needed v8.4.0 backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes and removed auto-backport Deprecated - use backport:version if exact versions are needed v8.4.0 labels Aug 8, 2022
@kpollich kpollich changed the title [Fleet] Edited the Kubernetes command [Fleet] Make Kubernetes manifest file extension consistent Aug 8, 2022
@kpollich kpollich merged commit aa1ce83 into elastic:main Aug 8, 2022
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.4

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 8, 2022
Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit aa1ce83)
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Aug 9, 2022
…#138340)

Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit aa1ce83)

Co-authored-by: Najmieh Sadat <[email protected]>
@ghost
Copy link
Author

ghost commented Aug 9, 2022

Thank you for merging this ^^

@ghost ghost deleted the kubernetes-command branch August 9, 2022 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) 💝community release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.4.0 v8.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants