[Archive Migration] batch 1 of removing es_archives/empty_kibana #138189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeeDr
added
7.14 candidate
test_xpack_functional
release_note:skip
watson
approved these changes
Aug 5, 2022
LeeDr
changed the title
|
@elasticmachine merge upstream |
kertal
approved these changes
Aug 9, 2022
|
@elasticmachine merge upstream |
tsullivan
approved these changes
Aug 10, 2022
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 12, 2022
Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit 6221b4f)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 13, 2022
…c#138747) Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit 6221b4f) Co-authored-by: Lee Drengenberg <[email protected]>
This was referenced Aug 23, 2022
Mpdreamz
pushed a commit
to Mpdreamz/kibana
that referenced
this pull request
Sep 6, 2022
Co-authored-by: Kibana Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #50373
Part of Meta issue: #102552
This PR removes the use of es_archives/empty_kibana and replaced it with calls to kibanaServer.savedObjects.cleanStandardList. I have changes queued up for the same change in more tests (30 more files at least).
WARNING: I should note that there is a difference between
esArchiver.load('x-pack/test/functional/es_archives/empty_kibana');(which I think deletes the entire .kibana index) andkibanaServer.savedObjects.cleanStandardList();(which can only delete savedObjects of types supported by the Saved Object API in the DEFAULT SPACE). There might be some types of saved objects which are not deleted. The full set we delete are here https://github.com/elastic/kibana/blob/main/packages/kbn-test/src/kbn_client/kbn_client_saved_objects.ts#L225 And saved objects in other spaces wouldn't be deleted. I mostly used find/replace to generate this PR and didn't review all the tests in detail. But the tests passed! The fact that our tests are broken up into so many separate configs probably helps with the isolation of tests.I checked and it looks like all the tests that created a space also already had an after method that deletes the space (and everything in it).