-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TIP] Restrict content visibility for non-enterprise users #138097
Conversation
am I correct that we keep our page in the navigation, but render nothing when not on enterprise? This approach is great if in the future we want to render "upgrade your license" fallback, but I think if we go with no fallback, then we would like to hide the app completely as with the feature flag - basically no nav item, no page available via direct link (redirect to Security Overview or smth). While we are waiting for the decision on the "upgrade your license block" and have our feature flag I think we can go ahead and merge it, but can happen that we will need to update the logic once more |
According to the comment in parent issue (on mobile, cannot paste it) - we are not going to hide anything in the nav. :) I will implement the specific fallback once the design is ready. |
@maxcold @lgmys looking at this comment from the Security Solution, it seems they don't care about having the plugin load but show nothing... Changes are implemented. I used a Redirect to the base route (goes to Get Started) when the Threat Intelligence feature isn't enabled |
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Public APIs missing exports
Page load bundle
History
To update your PR or re-run it, just comment with: |
@lgmys makes sense, as we are going with the fallback component "upgrade your license" the approach in the PR is good! |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…38097) (elastic#138358) (cherry picked from commit 335d63a) Co-authored-by: Luke Gmys <[email protected]>
Summary
I think this unit test sums it up best.
In short, this will restrict the nested components visiblity and render the fallback instead if
the user is below enterprise tier.
Checklist
Delete any items that are not applicable to this PR.