Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Fix flaky package install version integration test #138034

Merged

Conversation

nchaulet
Copy link
Member

@nchaulet nchaulet commented Aug 3, 2022

Summary

Resolve #137934

This integration test was failing as the synthetics package is automatically installed by synthetics (maybe we should provide a better way to install package automatically, or plugin should only install package on user action).

That PR remove that flakyness by explicitly specify which packages are used in this test.

@nchaulet nchaulet self-assigned this Aug 3, 2022
@nchaulet nchaulet added release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.4.0 v8.5.0 labels Aug 3, 2022
@nchaulet nchaulet marked this pull request as ready for review August 3, 2022 19:31
@nchaulet nchaulet requested a review from a team as a code owner August 3, 2022 19:31
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @nchaulet

@nchaulet nchaulet merged commit 319cba3 into elastic:main Aug 3, 2022
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 3, 2022
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.4

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@nchaulet nchaulet deleted the fix-flaky-upgrade-package-install-version branch August 3, 2022 20:30
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.4.0 v8.5.0
Projects
None yet
5 participants