Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Stack Monitoring] Skip Prometheus monitoring collection test when running on cloud #138003

Merged
merged 4 commits into from
Aug 11, 2022
Merged

[Stack Monitoring] Skip Prometheus monitoring collection test when running on cloud #138003

merged 4 commits into from
Aug 11, 2022

Conversation

crespocarlos
Copy link
Contributor

@crespocarlos crespocarlos commented Aug 3, 2022 •
edited by kibanamachine
Loading

Summary

This PR disables the Prometheus integration test for cloud runs.

In order for it to run it needs the environment to have a couple endpoints available, which are enabled in runtime by using a stub plugin and enabling Prometheus endpoint on the Kibana config file. However when running against a cloud deployment, there is nothing the test can do to enable them

Fixes #137740.

@crespocarlos crespocarlos added backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services Feature:Stack Monitoring v8.4.0 v8.5.0 release_note:skip Skip the PR/issue when compiling release notes and removed backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Aug 3, 2022
@crespocarlos
Copy link
Contributor Author

elasticmachine merge upstream

@crespocarlos crespocarlos changed the title Skip Prometheus monitoring collection test when running on cloud [Stack Monitoring] Skip Prometheus monitoring collection test when running on cloud Aug 3, 2022
@crespocarlos crespocarlos marked this pull request as ready for review August 4, 2022 07:28
@crespocarlos crespocarlos requested a review from a team as a code owner August 4, 2022 07:28
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

@miltonhultgren
Copy link
Contributor

I feel like we have more and more of these tests that are disabled in Cloud, should we maybe gather those somewhere and check what stops us from running those in Cloud and try to resolve that, you know to be more cloud first?

@crespocarlos
Copy link
Contributor Author

crespocarlos commented Aug 4, 2022 •
edited
Loading

There are some snapshot tests that fail on cloud, these could be refactored to compare only relevant fields. Another possibility could be removing fields that cause mismatches from the compared objects - if they are not relevant. In this case I think it could be adapted rather than skipped.

For this PR tough we have 2 problems. First, and the main blocker,monitoring_collection.opentelemetry.metrics setting has to be enabled to be used on Elastic Cloud (I'll open a follow up ticket to look into that, because I found this out this morning). Second, we need to find a way to enable/disable kibana settings on cloud deployment the same way we do locally, so that we can have the endpoint needed for this test available.

I think we can try to address these problems in follow up tickets

@crespocarlos
Copy link
Contributor Author

@elasticmachine merge upstream

@crespocarlos
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@crespocarlos crespocarlos merged commit 837343a into elastic:main Aug 11, 2022
@crespocarlos crespocarlos deleted the 137740-skip-prometheus-test-for-cloud-runs branch August 11, 2022 15:23
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 11, 2022
@crespocarlos
Skip Prometheus monitoring collection test when running on cloud (ela…
d514cde 
…stic#138003)

Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit 837343a)
@kibanamachine kibanamachine mentioned this pull request Aug 11, 2022
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.4

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Aug 11, 2022
@kibanamachine @crespocarlos
Skip Prometheus monitoring collection test when running on cloud (ela…
bd2c1ee 
…stic#138003) (elastic#138633)

Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit 837343a)

Co-authored-by: Carlos Crespo <[email protected]>
Mpdreamz pushed a commit to Mpdreamz/kibana that referenced this pull request Sep 6, 2022
@crespocarlos @kibanamachine @Mpdreamz
Skip Prometheus monitoring collection test when running on cloud (ela…
a2da922 
…stic#138003)

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miltonhultgren miltonhultgren miltonhultgren approved these changes

Assignees
No one assigned
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Feature:Stack Monitoring release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v8.4.0 v8.5.0
Projects
None yet
Milestone
No milestone
5 participants
@crespocarlos @elasticmachine @miltonhultgren @kibana-ci @kibanamachine