Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Private location] Add loading to delete location button #137846

Merged
merged 1 commit into from
Aug 2, 2022

Conversation

shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented Aug 2, 2022

Summary

Fixes comment elastic/uptime#475 (comment)

Added loading state to delete button

@shahzad31 shahzad31 requested a review from a team as a code owner August 2, 2022 13:19
@botelastic botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Aug 2, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@shahzad31 shahzad31 added release_note:skip Skip the PR/issue when compiling release notes v8.4.0 v8.5.0 labels Aug 2, 2022
@shahzad31 shahzad31 enabled auto-merge (squash) August 2, 2022 13:21
Copy link
Contributor

@emilioalvap emilioalvap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
synthetics 910.7KB 910.8KB +74.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@shahzad31 shahzad31 merged commit ae56b9f into elastic:main Aug 2, 2022
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 2, 2022
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.4

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@shahzad31 shahzad31 deleted the add-loading-delete branch August 2, 2022 14:32
kibanamachine added a commit that referenced this pull request Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.4.0 v8.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants