Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

68828 alert summary POC #137837

Closed
wants to merge 21 commits into from

Conversation

ersin-erdal
Copy link
Contributor

POC for alerts summary

#68828

@kibana-ci
Copy link
Collaborator

kibana-ci commented Aug 9, 2022

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #1 / action_form action_form in alert does not render "Add connector" button for preconfigured only action type
  • [job] [logs] Jest Tests #1 / action_form action_form in alert does not render action types disabled by config
  • [job] [logs] Jest Tests #1 / action_form action_form in alert recognizes actions with broken connectors
  • [job] [logs] Jest Tests #1 / action_form action_form in alert render action types which is preconfigured only (disabled by config and with preconfigured connectors)
  • [job] [logs] Jest Tests #1 / action_form action_form in alert renders action types disabled by license
  • [job] [logs] Jest Tests #1 / action_form action_form in alert renders available action cards
  • [job] [logs] Jest Tests #1 / action_form action_form in alert renders available action groups for the selected action type
  • [job] [logs] Jest Tests #1 / action_form action_form in alert renders available connectors for the selected action type
  • [job] [logs] Jest Tests #1 / action_form action_form in alert renders disabled action groups for custom recovered action groups
  • [job] [logs] Jest Tests #1 / action_form action_form in alert renders disabled action groups for selected action type
  • [job] [logs] Jest Tests #1 / action_form action_form in alert renders only preconfigured connectors for the selected preconfigured action type
  • [job] [logs] Jest Tests #1 / action_type_form calls "setActionParamsProperty" to set the default value for the empty dedupKey
  • [job] [logs] Jest Tests #1 / action_type_form does not call "setActionParamsProperty" because dedupKey is not empty
  • [job] [logs] Jest Tests #1 / action_type_form shows an error icon when there is a form error and the action accordion is closed
  • [job] [logs] FTR Configs #42 / Actions and Triggers app Home page Loads the app Alerts tab navigates to an alert details page
  • [job] [logs] FTR Configs #42 / Actions and Triggers app Home page Loads the app Alerts tab navigates to an alert details page
  • [job] [logs] Jest Tests #6 / alert_form alert_form > action_form action_form in alert renders available action cards
  • [job] [logs] Jest Tests #6 / alert_form alert_form edit alert should update throttle value
  • [job] [logs] FTR Configs #19 / alerting api integration basic license Alerts create gold noop rule should return 403 when creating an gold rule
  • [job] [logs] FTR Configs #19 / alerting api integration basic license Alerts create gold noop rule should return 403 when creating an gold rule
  • [job] [logs] FTR Configs #26 / alerting api integration security and spaces enabled Alerts - Group 1 alerts find public no_kibana_privileges at space1 should handle find alert request appropriately
  • [job] [logs] FTR Configs #26 / alerting api integration security and spaces enabled Alerts - Group 1 alerts find public no_kibana_privileges at space1 should handle find alert request appropriately
  • [job] [logs] FTR Configs #37 / alerting api integration security and spaces enabled - Group 2 Actions getAll no_kibana_privileges at space1 should handle get all request appropriately with proper referenced_by_count
  • [job] [logs] FTR Configs #37 / alerting api integration security and spaces enabled - Group 2 Actions getAll no_kibana_privileges at space1 should handle get all request appropriately with proper referenced_by_count
  • [job] [logs] FTR Configs #8 / alerting api integration spaces only Actions preconfigured alert history connector should index document with preconfigured schema
  • [job] [logs] FTR Configs #8 / alerting api integration spaces only Actions preconfigured alert history connector should index document with preconfigured schema
  • [job] [logs] FTR Configs #46 / apis uptime uptime REST endpoints uptime CRUD routes PrivateLocationMonitor "before all" hook for "adds a test fleet policy"
  • [job] [logs] FTR Configs #46 / apis uptime uptime REST endpoints uptime CRUD routes PrivateLocationMonitor "before all" hook for "adds a test fleet policy"
  • [job] [logs] FTR Configs #15 / APM API tests trial apm_mappings_only_8.0.0 fetching service anomalies with a trial license with ml jobs checks if alert is active
  • [job] [logs] FTR Configs #15 / APM API tests trial apm_mappings_only_8.0.0 fetching service anomalies with a trial license with ml jobs checks if alert is active
  • [job] [logs] Jest Tests #5 / create() calls the API key function
  • [job] [logs] Jest Tests #5 / create() creates a disabled alert
  • [job] [logs] Jest Tests #5 / create() creates a rule with some actions using preconfigured connectors
  • [job] [logs] Jest Tests #5 / create() creates an alert
  • [job] [logs] Jest Tests #5 / create() creates an alert with multiple actions
  • [job] [logs] Jest Tests #5 / create() doesn't create API key for disabled alerts
  • [job] [logs] Jest Tests #5 / create() sets legacyId when kibanaVersion is < 8.0.0
  • [job] [logs] Jest Tests #5 / create() should allow rule types to use action_ prefix for saved object reference names
  • [job] [logs] Jest Tests #5 / create() should call useSavedObjectReferences.extractReferences and useSavedObjectReferences.injectReferences if defined for rule type
  • [job] [logs] Jest Tests #5 / create() should create alert with given notifyWhen value if notifyWhen is not null
  • [job] [logs] Jest Tests #5 / create() should create alert with notifyWhen = onActiveAlert if notifyWhen is null and throttle is null
  • [job] [logs] Jest Tests #5 / create() should create alert with notifyWhen = onThrottleInterval if notifyWhen is null and throttle is set
  • [job] [logs] Jest Tests #5 / create() should create alerts with mapped_params
  • [job] [logs] Jest Tests #1 / createRule should call create alert API
  • [job] [logs] Security Solution Tests #1 / Custom query rules Custom detection rules deletion and edition Edition Allows a rule to be edited
  • [job] [logs] Rules, Alerts and Exceptions ResponseOps Cypress Tests on Security Solution / Custom query rules Custom detection rules deletion and edition Edition Allows a rule to be edited
  • [job] [logs] Security Solution Tests #1 / Custom query rules Custom detection rules deletion and edition Edition Allows a rule to be edited
  • [job] [logs] Rules, Alerts and Exceptions ResponseOps Cypress Tests on Security Solution / Custom query rules Custom detection rules deletion and edition Edition Allows a rule to be edited
  • [job] [logs] FTR Configs #1 / detection engine api security and spaces enabled - Group 1 throttle adding actions creating a rule When creating throttle with "NOTIFICATION_THROTTLE_NO_ACTIONS" set and no actions, the rule should have its kibana alerting "mute_all" set to "true" and notify_when set to "onActiveAlert"
  • [job] [logs] FTR Configs #1 / detection engine api security and spaces enabled - Group 1 throttle adding actions creating a rule When creating throttle with "NOTIFICATION_THROTTLE_NO_ACTIONS" set and no actions, the rule should have its kibana alerting "mute_all" set to "true" and notify_when set to "onActiveAlert"
  • [job] [logs] FTR Configs #23 / Execution context Server-side apps propagates context for Task and Alerts
  • [job] [logs] FTR Configs #23 / Execution context Server-side apps propagates context for Task and Alerts
  • [job] [logs] Jest Tests #1 / loadRule should call get API with base parameters
  • [job] [logs] FTR Configs #15 / machine learning - anomaly detection anomaly explorer with farequote based multi metric job renders View By swim lane
  • [job] [logs] FTR Configs #15 / machine learning - anomaly detection anomaly explorer with farequote based multi metric job renders View By swim lane
  • [job] [logs] FTR Configs #6 / ObservabilityApp Observability Rules page Rules table "after all" hook for "changes the rule status to "disabled""
  • [job] [logs] FTR Configs #6 / ObservabilityApp Observability Rules page Rules table "after all" hook for "changes the rule status to "disabled""
  • [job] [logs] FTR Configs #6 / ObservabilityApp Observability Rules page Rules table "before all" hook for "shows the rules table "
  • [job] [logs] FTR Configs #6 / ObservabilityApp Observability Rules page Rules table "before all" hook for "shows the rules table "
  • [job] [logs] Jest Tests #1 / should correctly compare notifyWhen field
  • [job] [logs] Jest Tests #5 / Task Runner actionsPlugin.execute is called per alert alert that is scheduled
  • [job] [logs] Jest Tests #5 / Task Runner actionsPlugin.execute is called per alert alert that is scheduled (with ephemeral support)
  • [job] [logs] Jest Tests #5 / Task Runner skips firing actions for active alert if alert is muted
  • [job] [logs] Jest Tests #5 / Task Runner snoozing works as expected with muteAll: false; snoozeSchedule: [{"rRule":{"dtstart":"9999-12-31T12:34:56.789Z","tzid":"UTC","count":1},"duration":100000000}]
  • [job] [logs] Jest Tests #5 / Task Runner snoozing works as expected with muteAll: false; snoozeSchedule: null
  • [job] [logs] Jest Tests #5 / Task Runner snoozing works as expected with muteAll: false; snoozeSchedule: undefined
  • [job] [logs] Jest Tests #5 / Task Runner successfully executes the task
  • [job] [logs] Jest Tests #1 / updateRule should call rule update API

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
alerting 27 26 -1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
alerting 359 365 +6
triggersActionsUi 399 404 +5
total +11

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
triggersActionsUi 920.4KB 907.7KB -12.7KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
alerting 21 22 +1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
alerting 38.5KB 38.7KB +161.0B
infra 84.0KB 84.3KB +279.0B
triggersActionsUi 90.2KB 90.5KB +306.0B
total +746.0B

Saved Objects .kibana field count

Every field in each saved object type adds overhead to Elasticsearch. Kibana needs to keep the total field count below Elasticsearch's default limit of 1000 fields. Only specify field mappings for the fields you wish to search on or query. See https://www.elastic.co/guide/en/kibana/master/development-plugin-saved-objects.html#_mappings

id before after diff
alert 75 81 +6
Unknown metric groups

API count

id before after diff
alerting 368 374 +6
triggersActionsUi 420 425 +5
total +11

async chunk count

id before after diff
triggersActionsUi 92 90 -2

ESLint disabled in files

id before after diff
apm 14 13 -1
observability 6 5 -1
securitySolution 76 75 -1
total -3

ESLint disabled line counts

id before after diff
apm 87 84 -3
enterpriseSearch 10 8 -2
observability 47 46 -1
synthetics 61 55 -6
triggersActionsUi 182 186 +4
ux 10 9 -1
total -9

Total ESLint disabled count

id before after diff
apm 101 97 -4
enterpriseSearch 10 8 -2
observability 53 51 -2
securitySolution 496 495 -1
synthetics 67 61 -6
triggersActionsUi 186 190 +4
ux 13 12 -1
total -12

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ersin-erdal ersin-erdal deleted the 68828-alert-summary-poc branch December 22, 2022 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants