Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIP] Prevent IndicatorsTable flash #137829

Merged
merged 1 commit into from
Aug 2, 2022
Merged

[TIP] Prevent IndicatorsTable flash #137829

merged 1 commit into from
Aug 2, 2022

Conversation

lgestc
Copy link
Contributor

@lgestc lgestc commented Aug 2, 2022

Summary

This fixes visible glitch when ThreatIntelligence plugin is initialized.

Before - you can see the table flash for a sec before we see the landing page message about integrations etc.

screen-capture.1.webm

After:

screen-capture.2.webm

Checklist

Delete any items that are not applicable to this PR.

@lgestc lgestc requested a review from a team as a code owner August 2, 2022 11:23
@lgestc lgestc added release_note:skip Skip the PR/issue when compiling release notes v8.4.0 v8.5.0 labels Aug 2, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
threatIntelligence 58.1KB 58.1KB -1.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@lgestc lgestc added backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) and removed v8.4.0 v8.5.0 labels Aug 2, 2022
@lgestc lgestc merged commit 96d32ad into elastic:main Aug 2, 2022
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 2, 2022
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.4

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Aug 2, 2022
(cherry picked from commit 96d32ad)

Co-authored-by: Luke Gmys <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team: Protections Experience v8.4.0 v8.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants