Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Uptime] show monitor management button on-prem #137754

Conversation

dominiqueclarke
Copy link
Contributor

@dominiqueclarke dominiqueclarke commented Aug 1, 2022

Summary

Relates to elastic/uptime#475

Shows monitor management button when users are not on Cloud.

Testing

  1. Change the renderApp function in Uptime public plugin to renderApp(coreStart, plugins, corePlugins, params, false)
  2. Ensure that the monitor management button appears in the Uptime header

@dominiqueclarke dominiqueclarke added Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability auto-backport Deprecated - use backport:version if exact versions are needed v8.4.0 v8.5.0 release_note:skip Skip the PR/issue when compiling release notes labels Aug 1, 2022
@dominiqueclarke dominiqueclarke marked this pull request as ready for review August 1, 2022 16:44
@dominiqueclarke dominiqueclarke requested a review from a team as a code owner August 1, 2022 16:44
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@dominiqueclarke
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
synthetics 910.8KB 910.7KB -100.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dominiqueclarke dominiqueclarke added the bug Fixes for quality problems that affect the customer experience label Aug 1, 2022
@dominiqueclarke dominiqueclarke merged commit ecd40db into elastic:main Aug 1, 2022
@dominiqueclarke dominiqueclarke deleted the fix/uptime-private-locations-on-prem-show-monitor-management-btn branch August 1, 2022 18:38
kibanamachine pushed a commit that referenced this pull request Aug 1, 2022
Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit ecd40db)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.4

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

kibanamachine added a commit that referenced this pull request Aug 1, 2022
Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit ecd40db)

Co-authored-by: Dominique Clarke <[email protected]>
@lucasfcosta
Copy link
Contributor

When testing this, I've done the following:

  1. Removed all my Kibana settings which caused it to run on a cloud context. Here are the lines I've commented out:
    # xpack.cloud.id: something
    # xpack.uptime.service.tls.certificate: config/123-client.pem
    # xpack.uptime.service.tls.key: config/123-client.key
    # xpack.uptime.service.username: <REDACTED>
    # xpack.uptime.service.password: <REDACTED>
    # xpack.uptime.service.showExperimentalLocations: false
    # xpack.uptime.service.manifestUrl: http://localhost:8081/manifest.json
  2. Then, I've started a fresh Elastic Stack, deleting my old containers
  3. Finally, I've checked out the latest changes in the 8.4 branch and started Kibana, connecting it to my local ES.
  4. I then was still able to see the monitor management button by default.

CC @dominiqueclarke is there any other test you'd like me to do for this?

Also, please notice the snapshotted Kibana I have was also okay. It was pulled today and its tagged build date (found with docker inspect is org.label-schema.build-date": "2022-08-02T11:09:52.943Z").

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.4.0 v8.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants