Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover] Fix broken useDiscoverState #137413

Merged
merged 1 commit into from
Jul 28, 2022
Merged

[Discover] Fix broken useDiscoverState #137413

merged 1 commit into from
Jul 28, 2022

Conversation

kertal
Copy link
Member

@kertal kertal commented Jul 28, 2022 •
edited
Loading

Summary

Fix broken main caused by a #132012 Github. After the last CI run of #132012 , there was an commit depending on a variable that was renamed in #132012 ... this caused CI to fail

@kertal kertal self-assigned this Jul 28, 2022
@kertal kertal added release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. labels Jul 28, 2022
@kertal kertal marked this pull request as ready for review July 28, 2022 07:29
@kertal kertal requested a review from a team as a code owner July 28, 2022 07:29
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

stratoula
stratoula approved these changes Jul 28, 2022
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes everything seems to work fine now Matthias! LGTM!

@kertal kertal requested a review from stratoula July 28, 2022 07:40
stratoula
stratoula approved these changes Jul 28, 2022
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve as temporary member of the discovery team :D

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 500.5KB 500.4KB -44.0B
Unknown metric groups

ESLint disabled in files

id before after diff
apm 13 14 +1
observability 5 6 +1
securitySolution 76 77 +1
total +3

ESLint disabled line counts

id before after diff
apm 84 87 +3
enterpriseSearch 8 10 +2
observability 46 47 +1
synthetics 55 61 +6
ux 9 10 +1
total +13

Total ESLint disabled count

id before after diff
apm 97 101 +4
enterpriseSearch 8 10 +2
observability 51 53 +2
securitySolution 495 496 +1
synthetics 61 67 +6
ux 12 13 +1
total +16

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @kertal

@stratoula stratoula merged commit 2e49015 into elastic:main Jul 28, 2022
@kibanamachine kibanamachine added v8.5.0 backport:skip This commit does not require backporting labels Jul 28, 2022
@kertal kertal deleted the discover-fix-broken-main branch July 28, 2022 09:06
This was referenced Jul 28, 2022
Closed
Closed
Closed
Closed
This was referenced Aug 1, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stratoula stratoula stratoula approved these changes

Assignees

@kertal kertal

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kertal @elasticmachine @kibana-ci @stratoula @kibanamachine