-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APM] Diplay logs only matching trace.id
query
#136927
Conversation
Pinging @elastic/apm-ui (Team:apm) |
@kpatticha I assumed the wider matching was intentional, maybe to also display non-ECS compatible log messages. It's also how we link to the Logs UI. Did we run this by @alex-fedotyev? I think he is the in-house APM logs expert 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't it make sense to also change the link in
kibana/x-pack/plugins/apm/public/components/shared/transaction_action_menu/sections.ts
Line 171 in d16a4d8
filter: `trace.id:"${transaction.trace.id}" OR "${transaction.trace.id}"`, |
No Cyrille opened a bug for this. . @alex-fedotyev what do you think about this change? |
I originally suggested the wider matching in #79995. I can't remember why and cannot find any discussion of this so I suggest to go ahead with this change (as long as @alex-fedotyev don't have any objections). |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
* [APM] Diplay logs only matching `trace.id` query * Fix log stream query * Update unit tests (cherry picked from commit 1e56f9b)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
* [APM] Diplay logs only matching `trace.id` query * Fix log stream query * Update unit tests (cherry picked from commit 1e56f9b) Co-authored-by: Katerina Patticha <[email protected]>
Summary
closes: #126342
related
#85859 (comment)