Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[User Experience App] Improve initial loading time of the app #136612

Merged
merged 8 commits into from
Jul 22, 2022

Conversation

shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented Jul 19, 2022

Summary

Improved loading of the app !!

Use context to load data view !!

Use local storage to lazy load data view title !!

This improves the loading of the app and avoid unnecessary calls to load data view !!

Testing

Smoke testing the app should be enough. just make sure all the widgets loads.

@shahzad31 shahzad31 marked this pull request as ready for review July 20, 2022 21:14
@shahzad31 shahzad31 requested a review from a team as a code owner July 20, 2022 21:14
@shahzad31 shahzad31 added v8.4.0 release_note:skip Skip the PR/issue when compiling release notes labels Jul 20, 2022
@botelastic botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Jul 20, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
ux 148 149 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ux 162.8KB 164.0KB +1.2KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@justinkambic justinkambic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shahzad31 shahzad31 merged commit d16a4d8 into elastic:main Jul 22, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jul 22, 2022
@shahzad31 shahzad31 deleted the ux-performance branch July 22, 2022 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants