Adding deprecation warning for Interactive Users using ApiKeys #136422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kc13greiner
added
Team:Security
|
Pinging @elastic/kibana-security (Team:Security) |
legrego
reviewed
Jul 18, 2022
gchaps
reviewed
Jul 18, 2022
| expect(routeParamsMock.analyticsService.reportAuthenticationTypeEvent).toHaveBeenCalledWith({ | ||
| authenticationProviderType: 'http', | ||
| authenticationRealmType: 'native', | ||
| httpAuthenticationScheme: 'Custom', | ||
| }); | ||
| }); | ||
| }); | ||
|
|
||
| describe('logApiKeyWithInteractiveUserDeprecated', () => { | ||
| it('should log a deprecation warning if interactive user is using API Key', async () => { |
There was a problem hiding this comment.
"interactive user" is not a term I normally see. Can we drop "interactive" or find another way to explain what is meant here?
There was a problem hiding this comment.
How about something like:
should log a deprecation warning if a user is authenticating via API key while accessing the application through a web browser
Co-authored-by: Larry Gregory <[email protected]>
Co-authored-by: Larry Gregory <[email protected]>
legrego
reviewed
Jul 19, 2022
Co-authored-by: Larry Gregory <[email protected]>
Co-authored-by: Larry Gregory <[email protected]>
|
Docs LGTM, pending Oleg's review. Thanks for the edits! |
azasypkin
approved these changes
Jul 20, 2022
x-pack/plugins/security/server/routes/analytics/authentication_type.test.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/security/server/routes/analytics/authentication_type.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/security/server/routes/analytics/authentication_type.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/security/server/routes/analytics/authentication_type.test.ts
Outdated
Show resolved
Hide resolved
…_type.test.ts Co-authored-by: Aleh Zasypkin <[email protected]>
…_type.ts Co-authored-by: Aleh Zasypkin <[email protected]>
…_type.ts Co-authored-by: Aleh Zasypkin <[email protected]>
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #120804
Preview of docs:
Release Notes