Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't allow_partial_search_results in readWithPit #136419

Merged
merged 2 commits into from
Jul 18, 2022
Merged

Don't allow_partial_search_results in readWithPit #136419

merged 2 commits into from
Jul 18, 2022

Conversation

gsoldevila
Copy link
Contributor

Fixes #136271

@gsoldevila gsoldevila requested a review from a team as a code owner July 14, 2022 16:22
@gsoldevila gsoldevila added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v8.4.0 v7.17.6 v8.3.3 labels Jul 14, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

gsoldevila
gsoldevila commented Jul 14, 2022
View reviewed changes
src/core/server/saved_objects/migrations/actions/read_with_pit.ts
query,
},
// Sort fields are required to use searchAfter
sort: '_shard_doc:asc',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got rid of the "body" property and bubbled everything up one level.
The sort field is now a simple string (or a list of strings) with a field:order naming convention.
I did a small exercise to validate this:

image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for the record regarding the body.sort and sort difference with current implementation: elastic/elasticsearch-js#1589

@gsoldevila gsoldevila enabled auto-merge (squash) July 14, 2022 16:31
pgayvallet
pgayvallet approved these changes Jul 18, 2022
View reviewed changes
Copy link
Contributor

@pgayvallet pgayvallet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/core/server/saved_objects/migrations/actions/read_with_pit.ts
query,
},
// Sort fields are required to use searchAfter
sort: '_shard_doc:asc',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for the record regarding the body.sort and sort difference with current implementation: elastic/elasticsearch-js#1589

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@gsoldevila gsoldevila merged commit e677179 into elastic:main Jul 18, 2022
kibanamachine pushed a commit that referenced this pull request Jul 18, 2022
@gsoldevila
Don't allow_partial_search_results in readWithPit (#136419)
d5d95f6 
(cherry picked from commit e677179)
@kibanamachine kibanamachine mentioned this pull request Jul 18, 2022
Merged
kibanamachine pushed a commit that referenced this pull request Jul 18, 2022
@gsoldevila
Don't allow_partial_search_results in readWithPit (#136419)
8df3982 
(cherry picked from commit e677179)
@kibanamachine kibanamachine mentioned this pull request Jul 18, 2022
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 7.17
✅ 8.3

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jul 18, 2022
@kibanamachine @gsoldevila
Don't allow_partial_search_results in readWithPit (#136419) (#136510)
b589ff9 
(cherry picked from commit e677179)

Co-authored-by: Gerard Soldevila <[email protected]>
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jul 20, 2022
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

4 similar comments
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

kibanamachine added a commit that referenced this pull request Jul 26, 2022
@kibanamachine @gsoldevila
[7.17] Don't allow_partial_search_results in readWithPit (#136419) (#…
cb8fd9f 
…136509)

* Don't allow_partial_search_results in readWithPit (#136419)

(cherry picked from commit e677179)

* Fix failing backport

Co-authored-by: Gerard Soldevila <[email protected]>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgayvallet pgayvallet pgayvallet approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.17.6 v8.3.3 v8.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

migrations Actions.readWithPit must use allow_partial_search_results=false
5 participants
@gsoldevila @elasticmachine @kibana-ci @kibanamachine @pgayvallet