-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Data Visualizer: Remove duplicated geo examples, support 'version' type, add filters for boolean fields, and add sticky header to Discover #136236
Conversation
8629402
to
e923e33
Compare
e923e33
to
4b64a60
Compare
Pinging @elastic/ml-ui (:ml) |
...ion/common/components/expanded_row/geo_point_content_with_map/geo_point_content_with_map.tsx
Outdated
Show resolved
Hide resolved
...ion/common/components/expanded_row/geo_point_content_with_map/geo_point_content_with_map.tsx
Outdated
Show resolved
Hide resolved
9e8b3c5
to
3dc8912
Compare
@@ -40,6 +40,7 @@ export const JOB_FIELD_TYPES = { | |||
TEXT: 'text', | |||
HISTOGRAM: 'histogram', | |||
UNKNOWN: 'unknown', | |||
VERSION: 'version', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit, UNKNOWN
should be the last item in this list
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not for this PR, but JOB_FIELD_TYPES
should probably be replaced with ES_FIELD_TYPES
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated here cc5f0fd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested latest changes and LGTM.
Love the sticky table header in Discover!
1ab83b9
to
cc5f0fd
Compare
…o-bool-filter-version-icon
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sass changes LGTM.
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: cc @qn895 |
Summary
This PR is part of #86387. It adds several enhancements:
Geo fields no longer show duplicated results.
Field stats in Discover now have a sticky header when table is scrolled (see issue [Discover] Pin header row in Field Statistics when scrolling #136299):
Screen.Recording.2022-07-13.at.16.11.50.mov
Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers