Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Archive Migrations] Migrate discover for visual regression #136222

Merged
merged 4 commits into from
Jul 14, 2022
Merged

[Archive Migrations] Migrate discover for visual regression #136222

merged 4 commits into from
Jul 14, 2022

Conversation

wayneseymour
Copy link
Member

Summary

Add archive.
Make the test use the new archive.

@wayneseymour wayneseymour self-assigned this Jul 12, 2022
@wayneseymour wayneseymour added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v8.4.0 and removed v8.0.0 labels Jul 12, 2022
@wayneseymour wayneseymour marked this pull request as ready for review July 12, 2022 16:59
liza-mae
liza-mae approved these changes Jul 12, 2022
View reviewed changes
Copy link
Contributor

@liza-mae liza-mae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the discover test is failing (but it was failing before so unrelated to these changes)

@wayneseymour
Copy link
Member Author

LGTM, the discover test is failing (but it was failing before so unrelated to these changes)

@liza-mae awesome! I'm gonna drop the archive (if possible) and re-push.
If it passes on my end (buildkite) and on your end (jenkins), I think we are good to go.

@wayneseymour wayneseymour mentioned this pull request Jul 13, 2022
Closed
@wayneseymour wayneseymour force-pushed the migrations/discover-visual-regression branch from 9a8b8fd to abfc7b0 Compare July 13, 2022 08:19
@wayneseymour wayneseymour force-pushed the migrations/discover-visual-regression branch from abfc7b0 to 4763335 Compare July 13, 2022 10:09
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

  • 💚 Build #57274 succeeded abfc7b02aae51269b18d750fa281bbb131f3df24
  • 💚 Build #57148 succeeded 9a8b8fd76d00a18f2962cf4f9d999a27a69884e9

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @wayneseymour

LeeDr
LeeDr approved these changes Jul 13, 2022
View reviewed changes
Copy link

@LeeDr LeeDr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wayneseymour wayneseymour merged commit fce0739 into elastic:main Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liza-mae liza-mae liza-mae approved these changes

@LeeDr LeeDr LeeDr approved these changes

Assignees

@wayneseymour wayneseymour

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wayneseymour @kibana-ci @LeeDr @liza-mae