Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate server-side preboot service to packages #136060

Merged
merged 10 commits into from
Jul 11, 2022
Merged

Migrate server-side preboot service to packages #136060

merged 10 commits into from
Jul 11, 2022

Conversation

TinaHeiligers
Copy link
Contributor

@TinaHeiligers TinaHeiligers commented Jul 9, 2022 •
edited
Loading

Summary

Fix #136036

Creates the following packages:

  • @kbn/core-preboot-server
  • @kbn/core-preboot-server-internal
  • @kbn/core-preboot-server-mocks
    and moves the public types, internal types and implementations, and service mocks into these packages, respectively.

@TinaHeiligers TinaHeiligers added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc backport:skip This commit does not require backporting v8.4.0 labels Jul 9, 2022
@TinaHeiligers TinaHeiligers marked this pull request as ready for review July 10, 2022 00:25
@TinaHeiligers TinaHeiligers requested review from a team as code owners July 10, 2022 00:25
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@TinaHeiligers TinaHeiligers added the release_note:skip Skip the PR/issue when compiling release notes label Jul 10, 2022
Bamieh
Bamieh approved these changes Jul 10, 2022
View reviewed changes
Copy link
Member

@Bamieh Bamieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TinaHeiligers
Copy link
Contributor Author

@elasticmachine merge upstream

@TinaHeiligers TinaHeiligers enabled auto-merge (squash) July 10, 2022 19:44
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/core-preboot-server-mocks - 6 +6

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
kibana 434 436 +2
Unknown metric groups

API count

id before after diff
@kbn/core-preboot-server - 5 +5
@kbn/core-preboot-server-mocks - 6 +6
core 2506 2501 -5
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@TinaHeiligers TinaHeiligers merged commit 6ed1d88 into elastic:main Jul 11, 2022
@TinaHeiligers TinaHeiligers deleted the kbn-136036-server-side-preboot branch July 11, 2022 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bamieh Bamieh Bamieh approved these changes

@azasypkin azasypkin azasypkin approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v8.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate core domain services to packages: Server-side Preboot service
6 participants
@TinaHeiligers @elasticmachine @kibana-ci @azasypkin @Bamieh @kibanamachine