Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove shelljs #136049

Merged
merged 2 commits into from
Jul 11, 2022
Merged

Remove shelljs #136049

merged 2 commits into from
Jul 11, 2022

Conversation

jbudz
Copy link
Member

@jbudz jbudz commented Jul 8, 2022

This is only used to remove a file. We can use del instead.

@jbudz
Remove shelljs
5032c9e 
This is only used to remove a file.  We can use del instead.
@jbudz jbudz added Team:QA Team label for QA Team backport:all-open Backport to all branches that could still receive a release release_note:skip Skip the PR/issue when compiling release notes labels Jul 8, 2022
@jbudz jbudz marked this pull request as ready for review July 8, 2022 22:21
@jbudz jbudz requested a review from a team as a code owner July 8, 2022 22:21
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-qa (Team:QA)

LeeDr
LeeDr approved these changes Jul 11, 2022
View reviewed changes
Copy link

@LeeDr LeeDr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jbudz jbudz merged commit d8553f5 into elastic:main Jul 11, 2022
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 7.17 Backport failed because of merge conflicts

You might need to backport the following PRs to 7.17:
- Bump node-sass to 7.0.1 (#136034)
- Bump Node.js to 16.16.0 (#135926)
- Bump moment to 2.29.4 (#135862)
❌ 8.3 Backport failed because of merge conflicts

You might need to backport the following PRs to 8.3:
- Bump node-sass to 7.0.1 (#136034)
- [jest] refactor config check (#135960)

Manual backport

To create the backport manually run:

node scripts/backport --pr 136049

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jul 12, 2022
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 136049 locally

1 similar comment
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 136049 locally

jbudz added a commit to jbudz/kibana that referenced this pull request Jul 13, 2022
@jbudz
[8.3] Remove shelljs (elastic#136049)
e7d2444 
This is only used to remove a file.  We can use del instead.
@jbudz jbudz mentioned this pull request Jul 13, 2022
Merged
@jbudz jbudz added v7.17.6 and removed v7.17.6 labels Jul 13, 2022
jbudz added a commit to jbudz/kibana that referenced this pull request Jul 13, 2022
@jbudz
[7.17] Remove shelljs (elastic#136049)
3f56953
@jbudz jbudz mentioned this pull request Jul 13, 2022
Merged
jbudz added a commit that referenced this pull request Jul 13, 2022
@jbudz
[8.3] Remove shelljs (#136049) (#136313)
267e99d 
This is only used to remove a file.  We can use del instead.
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jul 13, 2022
jbudz added a commit that referenced this pull request Jul 13, 2022
@jbudz
[7.17] Remove shelljs (#136049) (#136314)
1494505
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeeDr LeeDr LeeDr approved these changes

Assignees
No one assigned
Labels
backport:all-open Backport to all branches that could still receive a release release_note:skip Skip the PR/issue when compiling release notes Team:QA Team label for QA Team v7.17.6 v8.3.3 v8.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jbudz @elasticmachine @kibana-ci @kibanamachine @LeeDr