Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Marking the node.roles kibana.yml setting as technical preview #135932

Merged
merged 1 commit into from
Jul 7, 2022
Merged

Marking the node.roles kibana.yml setting as technical preview #135932

merged 1 commit into from
Jul 7, 2022

Conversation

kobelb
Copy link
Contributor

@kobelb kobelb commented Jul 7, 2022

The recently added node.roles setting is being used to trigger various conditional behavior in task-manager. While this implementation is being vetted and fully tested, it should be marked as experimental.

@kobelb kobelb requested a review from lukeelmers July 7, 2022 17:03
@kobelb kobelb added release_note:skip Skip the PR/issue when compiling release notes v9.0.0 v8.4.0 labels Jul 7, 2022
lukeelmers
lukeelmers approved these changes Jul 7, 2022
View reviewed changes
Copy link
Member

@lukeelmers lukeelmers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for doing this ❤️

@kobelb kobelb merged commit 8655730 into elastic:main Jul 7, 2022
@kobelb kobelb deleted the node-roles-preview branch July 7, 2022 20:55
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jul 11, 2022
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 135932 locally

1 similar comment
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 135932 locally

@kobelb kobelb added the backport:skip This commit does not require backporting label Jul 12, 2022
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jul 12, 2022
@jbudz jbudz added backport:skip This commit does not require backporting and removed backport:skip This commit does not require backporting v9.0.0 labels Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukeelmers lukeelmers lukeelmers approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kobelb @kibanamachine @lukeelmers @jbudz