Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary jest.config.js files #135891

Conversation

gsoldevila
Copy link
Contributor

@gsoldevila gsoldevila commented Jul 7, 2022

Just noticed on a failed build that core's jest tests seems to run twice
#135832 (comment)
So a failure shows up in Jest test #2 and Jest test #5

After analyzing the various jest.config.js files in the Kibana project, we noticed that the following 2 files:

  • src/core/jest.config.js
  • src/plugins/chart_expressions/jest.config.js

are causing tests to run twice, as their containing folders have subfolders that define more specific jest configurations.

@gsoldevila gsoldevila added bug Fixes for quality problems that affect the customer experience Team:Operations Team label for Operations Team release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v8.4.0 v7.17.6 labels Jul 7, 2022
@gsoldevila gsoldevila changed the title Exclude server and public folders from src/core config Remove unnecessary jest.config.js files Jul 7, 2022
@gsoldevila gsoldevila marked this pull request as ready for review July 7, 2022 13:51
@gsoldevila gsoldevila requested a review from a team as a code owner July 7, 2022 13:51
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@gsoldevila gsoldevila requested a review from a team as a code owner July 7, 2022 14:39
@kibana-ci
Copy link
Collaborator

kibana-ci commented Jul 7, 2022

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #6 / When displaying the Delete artfifact modal in the Artifact List Page should close modal if Cancel/Close buttons are clicked
  • [job] [logs] Jest Tests #6 / When displaying the Delete artfifact modal in the Artifact List Page should prevent modal from being closed while deletion is in flight
  • [job] [logs] Jest Tests #6 / When displaying the Delete artfifact modal in the Artifact List Page should show Cancel and Delete buttons enabled
  • [job] [logs] Jest Tests #6 / When displaying the Delete artfifact modal in the Artifact List Page should show success toast if deleted successfully

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@gsoldevila
Copy link
Contributor Author

Solved by #135960

@gsoldevila gsoldevila closed this Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.17.6 v8.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants