Removes webpack-directory-name-as-main dependency #13584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylersmalley
force-pushed
the
no-directory-as-main
branch
2 times, most recently
from
a53a6dd to
e133363
Compare
tylersmalley
force-pushed
the
no-directory-as-main
branch
from
e133363 to
20f9303
Compare
Signed-off-by: Tyler Smalley <[email protected]>
tylersmalley
force-pushed
the
no-directory-as-main
branch
from
20f9303 to
d2200c6
Compare
|
Jenkins, test it |
jbudz
approved these changes
Aug 23, 2017
|
@spalger, do you think I should backport this to 6.x? If we want to eventually bump Webpack there we should. |
|
@tylersmalley yeah |
tylersmalley
added a commit
that referenced
this pull request
Aug 25, 2017
Signed-off-by: Tyler Smalley <[email protected]>
|
6.x/6.1: 854f795 |
tylersmalley
added
release_note:breaking
release_note:fix
and removed
release_note:breaking
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This plugin is one aspect preventing us from upgrading Webpack. This plugin also adds confusion as Node's pattern is to use an index.