[Fleet] using point in time for agent status query to avoid discrepancy #135816
Conversation
botelastic
bot
added
the
Team:Fleet
|
Pinging @elastic/fleet (Team:Fleet) |
| kuery: joinKuerys( | ||
| ...[ | ||
| kuery, | ||
| filterKuery, | ||
| `${AGENTS_PREFIX}.attributes.active:true`, |
There was a problem hiding this comment.
adding active filter here is incorrect, as getAgentsByKuery adds it based on showInactive:
kibana/x-pack/plugins/fleet/server/services/agents/crud.ts
Lines 125 to 127 in bce1836
| await closePointInTime(esClient, pitId); | ||
| } | ||
|
|
||
| const result = { | ||
| total: allActive.total, |
There was a problem hiding this comment.
I noticed that total doesn't include inactive, is it intentional? It can be a little confusing, example:
{
"results": {
"total": 981,
"inactive": 20,
"online": 981,
"error": 0,
"offline": 0,
"updating": 0,
"other": 20,
"events": 0
}
}
There was a problem hiding this comment.
Inactive agents are the ones that have been unenrolled, so they're generally excluded from the status as they're not relevant most of the time. We should probably have two fields, one for the real total and one for the total active, but I think we should only do this in a non-breaking way. Maybe total (all active, deprecated) and all (all active and inactive) and active (all active)
There was a problem hiding this comment.
I agree, this would be cleaner.
Do you happen to know if there is any usage of other status? It might be good to deprecate that as well, as it seems confusing. It is not mentioned in the UI/docs either.
There was a problem hiding this comment.
I agree it is confusing. Total seems to be total active, which you don't assume from the name total, my vote would be to fix this.
There was a problem hiding this comment.
Raised an issue to deprecate total status: #135980
| @@ -54,6 +54,7 @@ export const TableRowActions: React.FunctionComponent<{ | |||
| onClick={(event) => { | |||
| onAddRemoveTagsClick((event.target as Element).closest('button')!); | |||
| }} | |||
| disabled={!agent.active} | |||
There was a problem hiding this comment.
small change to disable Add / remove tags action on inactive agents, like the other actions are disabled
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
|
@juliaElastic should we backport this to 8.3? |
Summary
Fix #134798
getAgentsByKueryandgetAgentsByKueryPitfunctionsshowInactive: falseparameter because there was an unnecessaryactive:truefilter added.Tested by:
GET kbn:/api/fleet/agent_statusonline + offline > total- did this by logging out when this happensChecklist