[Usage Collection] Use PIT for collecting UI/Usage Counters & AppUsage #135689
Conversation
afharo
added
Team:Core
|
Pinging @elastic/kibana-core (Team:Core) |
|
@elasticmachine merge upstream |
| soRepository: ISavedObjectsRepository, | ||
| findOptions: SavedObjectsCreatePointInTimeFinderOptions | ||
| ): Promise<Array<SavedObjectsFindResult<T>>> { | ||
| const finder = soRepository.createPointInTimeFinder<T>({ ...findOptions, perPage: 100 }); |
There was a problem hiding this comment.
Overall using a PIT search is definitely an improvement.
I still wonder if 100 is the correct batch size? I would have gone with 1k, to avoid having that much additional roundtrips with ES in case of a lot of SOs
There was a problem hiding this comment.
I used 100 only because that's the value we placed in the docs (so I assumed the recommendation). Happy to change it to any other value.
@lukeelmers as the writer of those docs. What do you think?
There was a problem hiding this comment.
I can see in the code we are defaulting to 1000. I'll change it to 1000 then 😇
There was a problem hiding this comment.
@lukeelmers as the writer of those docs. What do you think?
Yeah I think I probably just forgot to update the docs when we decided to go with 1000 as the default. There was nothing special about the number 100.
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
Summary
Resolves #96715
Related to #93770
For maintainers