Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Add install_format_version to package and reinstall on setup #135485

Merged
merged 6 commits into from
Jul 4, 2022

Conversation

nchaulet
Copy link
Member

@nchaulet nchaulet commented Jun 29, 2022

Summary

Resolve #121099

That PR allow to reinstall packages and related es assets, like index template, ... when we made a change on how we install them in Fleet.

To do so I added a new install_format_version on the package saved object and on setup if that version is less than the current version we reinstall packages.

This is covered by an integration test.

@nchaulet nchaulet added Team:Fleet Team label for Observability Data Collection Fleet team v8.4.0 labels Jun 29, 2022
@nchaulet nchaulet self-assigned this Jun 29, 2022
@nchaulet nchaulet force-pushed the feature-install-format-version branch from 9daa2fd to d406261 Compare June 29, 2022 20:50
@nchaulet nchaulet marked this pull request as ready for review June 30, 2022 18:43
@nchaulet nchaulet requested a review from a team as a code owner June 30, 2022 18:43
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@nchaulet nchaulet added the release_note:skip Skip the PR/issue when compiling release notes label Jun 30, 2022
Copy link
Contributor

@juliaElastic juliaElastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

@nchaulet
Copy link
Member Author

nchaulet commented Jul 4, 2022

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
fleet 1372 1373 +1

Saved Objects .kibana field count

Every field in each saved object type adds overhead to Elasticsearch. Kibana needs to keep the total field count below Elasticsearch's default limit of 1000 fields. Only specify field mappings for the fields you wish to search on or query. See https://www.elastic.co/guide/en/kibana/master/development-plugin-saved-objects.html#_mappings

id before after diff
epm-packages 19 20 +1
Unknown metric groups

API count

id before after diff
fleet 1503 1504 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @nchaulet

@nchaulet nchaulet merged commit 8c8da35 into elastic:main Jul 4, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jul 4, 2022
@nchaulet nchaulet deleted the feature-install-format-version branch July 4, 2022 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fleet] Changes in package install format should be applied on Stack upgrades
5 participants