Bumping EUI to v60.1.2. #135373

1Copenut · 2022-06-28T21:03:44Z

Summary

[email protected] ⏩ [email protected]

In this PR we've added a prop to the EuiScreenReaderLive component to allow it to receive keyboard focus. This is useful for situations like announcing route changes to screen readers.
Skip link overrideLinkBehavior handles focus halo on containers (sets the halo on initial focus, removes it when the container loses focus).

`60.1.2`

Bug fixes

Fixed EuiSelectable's onChange callback not passing back a persisted event on React 16 (#6026)
Fixed EuiText not correctly inheriting classNames when both the color and textAlign props were passed (#6027)

`60.1.1`

Bug fixes

Fixed issue with EuiPanel where the Emotion styles were not being passed when it was rendered as a button (#6010)

`60.1.0`

Added focusRegionOnTextChange prop to EuiScreenReaderLive (#5995)
Enhanced EuiSkipLink's overrideLinkBehavior scroll and focus UX (#5996)

Bug fixes

Fixed EuiAccordion props type not being correctly inferred (#5974)

CSS-in-JS conversions

Converted EuiScreenReaderOnly to Emotion (#5846)
Converted EuiIcon to Emotion; removed $euiIconLoadingOpacity, $euiIconColors, and $euiIconSizes (#5967)
Converted EuiProgress to Emotion and removed $euiProgressColors and $euiProgressSizes (#5986)

* Updating Lens drag and drop to account for Emotion wrapper. * Updating icon size in EUI theme object for test. * Updating Lens Editor Frame test to assert 1 click instead of 2.

-isLoaded was deprecated in favor of data-attrs - hook should still work

- these classNames no longer output meaningful CSS and should not be used

- (which will soon be deprecated by Emotion conversion) - use the generic euiSizes instead, which will likely be the last to be deprecated

- we should be using the `data-is-loaded` attribute that it was switched to

...ion/public/management/components/back_to_external_app_button/back_to_external_app_button.tsx

dominiqueclarke

LGTM

joeypoon

🚀

ogupte

LGTM

mattkime

app services changes lgtm

stratoula

VisEditors changes LGTM, I also tested it locally and everything seems to work fine

majagrubic · 2022-07-08T09:04:48Z

...x/button_toolbar/src/buttons/icon_button_group/__snapshots__/icon_button_group.test.tsx.snap

+              }
+            }
+          />
+          <legend


This doesn't seem right. Looks like there are two legend html tags now (the other one on line 159). The other seems redundant.

...es/shared-ux/button/exit_full_screen/src/__snapshots__/exit_full_screen_button.test.tsx.snap

1Copenut · 2022-07-08T14:25:43Z

@elasticmachine merge upstream

1Copenut · 2022-07-08T19:53:18Z

buildkite test this

…instance UI.

1Copenut · 2022-07-08T21:19:53Z

@elasticmachine merge upstream

1Copenut · 2022-07-11T13:49:50Z

@elasticmachine merge upstream

1Copenut · 2022-07-11T19:07:06Z

@elasticmachine merge upstream

kibana-ci · 2022-07-11T20:19:38Z

💛 Build succeeded, but was flaky

Failed CI Steps

APM Cypress Tests

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`apm`	3.0MB	3.0MB	-68.0B
`ml`	3.4MB	3.4MB	+14.0B
`securitySolution`	5.2MB	5.2MB	-40.0B
total			-94.0B

Canvas Sharable Runtime

The Canvas "shareable runtime" is an bundle produced to enable running Canvas workpads outside of Kibana. This bundle is included in third-party webpages that embed canvas and therefor should be as slim as possible.

id	before	after	diff
`module count`	4967	4970	+3
`total size`	7.7MB	7.7MB	-11.3KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`kbnUiSharedDeps-css`	543.5KB	533.7KB	-9.8KB
`kbnUiSharedDeps-npmDll`	5.0MB	5.0MB	+5.4KB
total			-4.4KB

History

💔 Build #56759 failed 4522f83
💛 Build #56668 was flaky 4522f83
💔 Build #56529 failed f9c50c0
💔 Build #56453 failed 10a17ca
💔 Build #56433 failed f91bf82

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @1Copenut

clintandrewhall

LGTM. We'll follow up with a switch to render for our snapshots, to reduce bloat.

Bumping EUI to v60.1.0.

b7ba54f

1Copenut added release_note:skip Skip the PR/issue when compiling release notes EUI backport:skip This commit does not require backporting ci:deploy-cloud v8.4.0 labels Jun 28, 2022

1Copenut self-assigned this Jun 28, 2022

1Copenut and others added 2 commits June 29, 2022 09:16

Merge branch 'main' into eui/60.1.0

86945b9

Bumping to bugfixed v60.1.1.

594d2df

1Copenut changed the title ~~Bumping EUI to v60.1.0.~~ Bumping EUI to v60.1.1. Jun 29, 2022

1Copenut added 4 commits June 29, 2022 16:21

Updating snapshots for EUI Emotion changes.

bd04738

Updating a theme icon size declaration.

041493d

Updating tests for Emotion and new EUI theme objects.

6d73c76

* Updating Lens drag and drop to account for Emotion wrapper. * Updating icon size in EUI theme object for test. * Updating Lens Editor Frame test to assert 1 click instead of 2.

Updating two Jest tests for Emotion extra wrapper.

6cbc6c0

flash1293 mentioned this pull request Jul 4, 2022

[Lens] fix suggestion panel styling #135622

Closed

1Copenut and others added 8 commits July 5, 2022 10:08

Changing a Cypress selector for Emotion classnames.

a972106

Update removed EuiIcon classes

a58679d

-isLoaded was deprecated in favor of data-attrs - hook should still work

Remove static EuiIcon classes from static SVG

24a32de

- these classNames no longer output meaningful CSS and should not be used

Fix theme JSON imports not to rely on any iconSizes keys

c0bbe0e

- (which will soon be deprecated by Emotion conversion) - use the generic euiSizes instead, which will likely be the last to be deprecated

Fix one more euiIcon-isLoaded className change

2f9814e

- we should be using the `data-is-loaded` attribute that it was switched to

Merge remote-tracking branch 'upstream/main' into eui/60.1.0

f6edfc7

Bumping EUI to 60.1.2 patch release.

6ba6626

Merge branch 'eui/60.1.0' of github.com:1Copenut/kibana into eui/60.1.0

5de82c4

1Copenut changed the title ~~Bumping EUI to v60.1.1.~~ Bumping EUI to v60.1.2. Jul 5, 2022

jeramysoucy mentioned this pull request Jul 6, 2022

Fixes Spaces Menu Keyboard and Screen Reader Navigation #134454

Merged

1Copenut and others added 2 commits July 6, 2022 08:37

Updating Storyshots for EUI 60.1.2.

1d4dceb

Merge branch 'main' into eui/60.1.0

74bb45e

1Copenut marked this pull request as ready for review July 6, 2022 17:08

1Copenut requested a review from a team July 6, 2022 17:08

1Copenut requested a review from a team as a code owner July 6, 2022 17:08

joeypoon reviewed Jul 7, 2022

View reviewed changes

...ion/public/management/components/back_to_external_app_button/back_to_external_app_button.tsx Show resolved Hide resolved

dominiqueclarke approved these changes Jul 7, 2022

View reviewed changes

joeypoon approved these changes Jul 7, 2022

View reviewed changes

ogupte approved these changes Jul 7, 2022

View reviewed changes

mattkime approved these changes Jul 7, 2022

View reviewed changes

Merge branch 'main' into eui/60.1.0

e110381

stratoula approved these changes Jul 8, 2022

View reviewed changes

majagrubic reviewed Jul 8, 2022

View reviewed changes

...es/shared-ux/button/exit_full_screen/src/__snapshots__/exit_full_screen_button.test.tsx.snap Show resolved Hide resolved

Merge branch 'main' into eui/60.1.0

96b6898

Removing two assertions from instances_table.spec to match localhost …

f91bf82

…instance UI.

1Copenut requested a review from majagrubic July 8, 2022 20:12

kibanamachine and others added 2 commits July 8, 2022 17:19

Merge branch 'main' into eui/60.1.0

10a17ca

Merge branch 'main' into eui/60.1.0

f9c50c0

Merge branch 'main' into eui/60.1.0

4522f83

MichaelMarcialis approved these changes Jul 11, 2022

View reviewed changes

paul-tavares approved these changes Jul 11, 2022

View reviewed changes

Merge branch 'main' into eui/60.1.0

9e3bd84

clintandrewhall approved these changes Jul 11, 2022

View reviewed changes

1Copenut merged commit e21e506 into elastic:main Jul 11, 2022

1Copenut deleted the eui/60.1.0 branch July 11, 2022 21:33

tylersmalley added ci:cloud-deploy Create or update a Cloud deployment and removed ci:deploy-cloud labels Aug 17, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bumping EUI to v60.1.2. #135373

Bumping EUI to v60.1.2. #135373

1Copenut commented Jun 28, 2022 •

edited

Loading

dominiqueclarke left a comment

joeypoon left a comment

ogupte left a comment

mattkime left a comment

stratoula left a comment

majagrubic Jul 8, 2022

1Copenut commented Jul 8, 2022 •

edited

Loading

1Copenut commented Jul 8, 2022

1Copenut commented Jul 8, 2022

1Copenut commented Jul 11, 2022

1Copenut commented Jul 11, 2022

kibana-ci commented Jul 11, 2022

clintandrewhall left a comment

Bumping EUI to v60.1.2. #135373

Bumping EUI to v60.1.2. #135373

Conversation

1Copenut commented Jun 28, 2022 • edited Loading

Summary

60.1.2

60.1.1

60.1.0

dominiqueclarke left a comment

Choose a reason for hiding this comment

joeypoon left a comment

Choose a reason for hiding this comment

ogupte left a comment

Choose a reason for hiding this comment

mattkime left a comment

Choose a reason for hiding this comment

stratoula left a comment

Choose a reason for hiding this comment

majagrubic Jul 8, 2022

Choose a reason for hiding this comment

1Copenut commented Jul 8, 2022 • edited Loading

1Copenut commented Jul 8, 2022

1Copenut commented Jul 8, 2022

1Copenut commented Jul 11, 2022

1Copenut commented Jul 11, 2022

kibana-ci commented Jul 11, 2022

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Canvas Sharable Runtime

Page load bundle

History

clintandrewhall left a comment

Choose a reason for hiding this comment

1Copenut commented Jun 28, 2022 •

edited

Loading

`60.1.2`

`60.1.1`

`60.1.0`

1Copenut commented Jul 8, 2022 •

edited

Loading