Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX Dashboard] Unify processor event #135367

Merged
merged 13 commits into from
Aug 2, 2022

Conversation

justinkambic
Copy link
Contributor

@justinkambic justinkambic commented Jun 28, 2022

Summary

Note to reviewers: this PR depends on #135072, do not review until that one is merged.

Per this comment from the UX dashboard migration effort, the ProcessorEvent enum is shared between APM and UX, so this PR looks to consolidate it into the Observability plugin and reference it from there.

@justinkambic justinkambic added Team:APM All issues that need APM UI Team support technical debt Improvement of the software architecture and operational architecture Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability release_note:skip Skip the PR/issue when compiling release notes v8.4.0 labels Jun 28, 2022
@justinkambic justinkambic self-assigned this Jun 28, 2022
@justinkambic justinkambic marked this pull request as ready for review July 20, 2022 17:27
@justinkambic justinkambic requested review from a team as code owners July 20, 2022 17:27
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@matschaffer matschaffer self-requested a review July 22, 2022 04:54
Copy link
Contributor

@matschaffer matschaffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like @elastic/infra-monitoring-ui just got tagged due to some import reordering, but +1 on the PR as a whole too. Nice to be sharing type definitions :)

Copy link
Contributor

@gbamparop gbamparop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for picking it up!

@emilioalvap
Copy link
Contributor

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

merge conflict between base and head

@dominiqueclarke
Copy link
Contributor

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
apm 1306 1305 -1
observability 474 475 +1
ux 149 148 -1
total -1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
apm 40 39 -1
observability 388 389 +1
total -0

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 3.0MB 3.0MB +18.0B
ux 163.9KB 163.7KB -145.0B
total -127.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
apm 54 53 -1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
observability 64.6KB 64.7KB +178.0B
ux 5.7KB 5.8KB +143.0B
total +321.0B
Unknown metric groups

API count

id before after diff
apm 40 39 -1
observability 391 392 +1
total -0

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @justinkambic

@justinkambic justinkambic merged commit 2f7603d into elastic:main Aug 2, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Aug 2, 2022
@justinkambic justinkambic deleted the 454/unify-processor-event branch August 2, 2022 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability technical debt Improvement of the software architecture and operational architecture v8.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants