Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI Framework][K7] Clean up toasts #13502

Merged
merged 6 commits into from
Aug 14, 2017
Merged

[UI Framework][K7] Clean up toasts #13502

merged 6 commits into from
Aug 14, 2017

Conversation

snide
Copy link
Contributor

@snide snide commented Aug 14, 2017

Replaces #13480

Pretties up the toasts and their documentation. Also makes them responsive.

image

image

@snide snide requested a review from cjcenizal August 14, 2017 18:07
@snide snide mentioned this pull request Aug 14, 2017
Closed
@snide snide added the Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. label Aug 14, 2017
cjcenizal
cjcenizal approved these changes Aug 14, 2017
View reviewed changes
Copy link
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Might want to consider a clearer focus state for the close button though. In my original PR I added the blue focus background and made the X blue, which looked pretty good and consistent with other focus states.

@snide snide merged commit d5197df into elastic:k7-ui-framework Aug 14, 2017
@snide snide deleted the k7/toast_clean branch August 14, 2017 22:20
cjcenizal pushed a commit to cjcenizal/kibana that referenced this pull request Aug 16, 2017
@snide @cjcenizal
[UI Framework][K7] Clean up toasts (elastic#13502)
6bf6f07 
Prettier toasts that are responsive.
cjcenizal pushed a commit to cjcenizal/kibana that referenced this pull request Aug 26, 2017
@snide @cjcenizal
[UI Framework][K7] Clean up toasts (elastic#13502)
7e1468b 
Prettier toasts that are responsive.
cjcenizal pushed a commit that referenced this pull request Sep 19, 2017
@snide @cjcenizal
[UI Framework][K7] Clean up toasts (#13502)
3bc886c 
Prettier toasts that are responsive.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjcenizal cjcenizal cjcenizal approved these changes

Assignees
No one assigned
Labels
Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@snide @cjcenizal